DirectedChannelInfo to PaymentRelay mapping

Author: jkczyz

lightning/src/blinded_path/payment.rs

@@ -13,6 +13,7 @@ use crate::ln::features::BlindedHopFeatures;
 use crate::ln::msgs::DecodeError;
 use crate::offers::invoice::BlindedPayInfo;
 use crate::prelude::*;
+use crate::routing::gossip::DirectedChannelInfo;
 use crate::util::ser::{Readable, Writeable, Writer};
 
 use core::convert::TryFrom;
@@ -97,6 +98,19 @@ pub struct PaymentConstraints {
 	pub htlc_minimum_msat: u64,
 }
 
+impl PaymentRelay {
+	fn normalize_cltv_expiry_delta(cltv_expiry_delta: u16) -> Result<u16, ()> {
+		// Avoid exposing esoteric CLTV expiry deltas, which could de-anonymize the path.
+		match cltv_expiry_delta {
+			0..=40 => Ok(40),
+			41..=80 => Ok(80),
+			81..=144 => Ok(144),
+			145..=216 => Ok(216),
+			_ => Err(()),
+		}
+	}
+}
+
 impl TryFrom<CounterpartyForwardingInfo> for PaymentRelay {
 	type Error = ();
 
@@ -105,16 +119,25 @@ impl TryFrom<CounterpartyForwardingInfo> for PaymentRelay {
 			fee_base_msat, fee_proportional_millionths, cltv_expiry_delta
 		} = info;
 
-		// Avoid exposing esoteric CLTV expiry deltas
-		let cltv_expiry_delta = match cltv_expiry_delta {
-			0..=40 => 40,
-			41..=80 => 80,
-			81..=144 => 144,
-			145..=216 => 216,
-			_ => return Err(()),
-		};
+		Ok(Self {
+			cltv_expiry_delta: Self::normalize_cltv_expiry_delta(cltv_expiry_delta)?,
+			fee_proportional_millionths,
+			fee_base_msat
+		})
+	}
+}
+
+impl<'a> TryFrom<DirectedChannelInfo<'a>> for PaymentRelay {
+	type Error = ();
+
+	fn try_from(info: DirectedChannelInfo<'a>) -> Result<Self, ()> {
+		let direction = info.direction();
 
-		Ok(Self { cltv_expiry_delta, fee_proportional_millionths, fee_base_msat })
+		Ok(Self {
+			cltv_expiry_delta: Self::normalize_cltv_expiry_delta(direction.cltv_expiry_delta)?,
+			fee_proportional_millionths: direction.fees.proportional_millionths,
+			fee_base_msat: direction.fees.base_msat,
+		})
 	}
 }
 

lightning/src/routing/gossip.rs

@@ -1026,7 +1026,7 @@ impl<'a> DirectedChannelInfo<'a> {
 
 	/// Returns information for the direction.
 	#[inline]
-	pub(super) fn direction(&self) -> &'a ChannelUpdateInfo { self.direction }
+	pub(crate) fn direction(&self) -> &'a ChannelUpdateInfo { self.direction }
 
 	/// Returns the `node_id` of the source hop.
 	///