Skip to content

Commit 580db46

Browse files
committed
Describe ConfirmationTarget::MaximumFeeEstimate more accurately
This isn't really just the maximum estimate that we want from our fee estimator but rather the maximum estimate that we think is reasonable to receive from our counterparty. Thus, we should really describe it as such and suggest users add a fudge on top to accomodate disagreements.
1 parent 0a202c1 commit 580db46

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

lightning/src/chain/chaininterface.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -49,11 +49,14 @@ pub trait BroadcasterInterface {
4949
/// estimation.
5050
#[derive(Clone, Copy, Debug, Hash, PartialEq, Eq)]
5151
pub enum ConfirmationTarget {
52-
/// The most aggressive (i.e. highest) feerate estimate available.
52+
/// The most aggressive feerate estimate which we think is reasonable.
5353
///
5454
/// This is used to sanity-check our counterparty's feerates and should be as conservative as
5555
/// possible to ensure that we don't confuse a peer using a very conservative estimator for one
56-
/// trying to burn channel balance to dust.
56+
/// trying to burn channel balance to dust. To ensure that this is never lower than an honest
57+
/// counterparty's feerate estimate you may wish to use a value which is higher than your
58+
/// maximum feerate estimate, for example by adding a constant few-hundred or few-thousand
59+
/// sats-per-kW.
5760
MaximumFeeEstimate,
5861
/// We have some funds available on chain which we need to spend prior to some expiry time at
5962
/// which point our counterparty may be able to steal them.

0 commit comments

Comments
 (0)