Skip to content

Commit 5c9dc22

Browse files
committed
Handle splice_locked message
1 parent ebfb8f8 commit 5c9dc22

File tree

2 files changed

+90
-3
lines changed

2 files changed

+90
-3
lines changed

lightning/src/ln/channel.rs

Lines changed: 35 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9338,6 +9338,41 @@ impl<SP: Deref> FundedChannel<SP> where
93389338
Ok(())
93399339
}
93409340

9341+
#[cfg(splicing)]
9342+
pub fn splice_locked<NS: Deref, L: Deref>(
9343+
&mut self, msg: &msgs::SpliceLocked, node_signer: &NS, chain_hash: ChainHash,
9344+
user_config: &UserConfig, best_block: &BestBlock, logger: &L,
9345+
) -> Result<Option<msgs::AnnouncementSignatures>, ChannelError>
9346+
where
9347+
NS::Target: NodeSigner,
9348+
L::Target: Logger
9349+
{
9350+
let pending_splice = match self.pending_splice.as_mut() {
9351+
Some(pending_splice) => pending_splice,
9352+
None => {
9353+
return Err(ChannelError::Ignore(format!("Channel is not in pending splice")));
9354+
},
9355+
};
9356+
9357+
if let Some(sent_funding_txid) = pending_splice.sent_funding_txid {
9358+
if sent_funding_txid == msg.splice_txid {
9359+
if let Some(funding) = self.pending_funding
9360+
.iter_mut()
9361+
.find(|funding| funding.get_funding_txid() == Some(sent_funding_txid))
9362+
{
9363+
promote_splice_funding!(self, funding);
9364+
return Ok(self.get_announcement_sigs(node_signer, chain_hash, user_config, best_block.height, logger));
9365+
}
9366+
9367+
let err = "unknown splice funding txid";
9368+
return Err(ChannelError::close(err.to_string()));
9369+
}
9370+
}
9371+
9372+
pending_splice.received_funding_txid = Some(msg.splice_txid);
9373+
Ok(None)
9374+
}
9375+
93419376
// Send stuff to our remote peers:
93429377

93439378
/// Queues up an outbound HTLC to send by placing it in the holding cell. You should call

lightning/src/ln/channelmanager.rs

Lines changed: 55 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9637,6 +9637,51 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
96379637
Err(MsgHandleErrInternal::send_err_msg_no_close("TODO(splicing): Splicing is not implemented (splice_ack)".to_owned(), msg.channel_id))
96389638
}
96399639

9640+
#[cfg(splicing)]
9641+
fn internal_splice_locked(&self, counterparty_node_id: &PublicKey, msg: &msgs::SpliceLocked) -> Result<(), MsgHandleErrInternal> {
9642+
let per_peer_state = self.per_peer_state.read().unwrap();
9643+
let peer_state_mutex = per_peer_state.get(counterparty_node_id)
9644+
.ok_or_else(|| {
9645+
debug_assert!(false);
9646+
MsgHandleErrInternal::send_err_msg_no_close(format!("Can't find a peer matching the passed counterparty node_id {}", counterparty_node_id), msg.channel_id)
9647+
})?;
9648+
let mut peer_state_lock = peer_state_mutex.lock().unwrap();
9649+
let peer_state = &mut *peer_state_lock;
9650+
9651+
// Look for the channel
9652+
match peer_state.channel_by_id.entry(msg.channel_id) {
9653+
hash_map::Entry::Vacant(_) => return Err(MsgHandleErrInternal::send_err_msg_no_close(format!(
9654+
"Got a message for a channel from the wrong node! No such channel for the passed counterparty_node_id {}",
9655+
counterparty_node_id
9656+
), msg.channel_id)),
9657+
hash_map::Entry::Occupied(mut chan_entry) => {
9658+
if let Some(chan) = chan_entry.get_mut().as_funded_mut() {
9659+
let logger = WithChannelContext::from(&self.logger, &chan.context, None);
9660+
let announcement_sigs_opt = try_channel_entry!(
9661+
self, peer_state, chan.splice_locked(
9662+
msg, &self.node_signer, self.chain_hash, &self.default_configuration,
9663+
&self.best_block.read().unwrap(), &&logger,
9664+
), chan_entry
9665+
);
9666+
if let Some(announcement_sigs) = announcement_sigs_opt {
9667+
let mut short_to_chan_info = self.short_to_chan_info.write().unwrap();
9668+
insert_short_channel_id!(short_to_chan_info, chan);
9669+
9670+
log_trace!(logger, "Sending announcement_signatures for channel {}", chan.context.channel_id());
9671+
peer_state.pending_msg_events.push(MessageSendEvent::SendAnnouncementSignatures {
9672+
node_id: counterparty_node_id.clone(),
9673+
msg: announcement_sigs,
9674+
});
9675+
}
9676+
} else {
9677+
return Err(MsgHandleErrInternal::send_err_msg_no_close("Channel is not funded, cannot splice".to_owned(), msg.channel_id));
9678+
}
9679+
},
9680+
};
9681+
9682+
Ok(())
9683+
}
9684+
96409685
/// Process pending events from the [`chain::Watch`], returning whether any events were processed.
96419686
fn process_pending_monitor_events(&self) -> bool {
96429687
debug_assert!(self.total_consistency_lock.try_write().is_err()); // Caller holds read lock
@@ -12160,9 +12205,16 @@ where
1216012205

1216112206
#[cfg(splicing)]
1216212207
fn handle_splice_locked(&self, counterparty_node_id: PublicKey, msg: &msgs::SpliceLocked) {
12163-
let _: Result<(), _> = handle_error!(self, Err(MsgHandleErrInternal::send_err_msg_no_close(
12164-
"Splicing not supported (splice_locked)".to_owned(),
12165-
msg.channel_id)), counterparty_node_id);
12208+
let _persistence_guard = PersistenceNotifierGuard::optionally_notify(self, || {
12209+
let res = self.internal_splice_locked(&counterparty_node_id, msg);
12210+
let persist = match &res {
12211+
Err(e) if e.closes_channel() => NotifyOption::DoPersist,
12212+
Err(_) => NotifyOption::SkipPersistHandleEvents,
12213+
Ok(()) => NotifyOption::DoPersist,
12214+
};
12215+
let _ = handle_error!(self, res, counterparty_node_id);
12216+
persist
12217+
});
1216612218
}
1216712219

1216812220
fn handle_shutdown(&self, counterparty_node_id: PublicKey, msg: &msgs::Shutdown) {

0 commit comments

Comments
 (0)