Use owned UpdateFulfillHTLC msg to avoid attribution data clones

In the previous commit we switched to passing `UpdateFulfillHTLC`
messages to handlers owned, rather than by reference. Here we
update `ChanelManager`'s handling of fulfill attribution data to
avoid unnecessary clones now that we own the object.

Author: TheBlueMatt

lightning/src/ln/channelmanager.rs

@@ -7898,7 +7898,7 @@ where
 					};
 
 				let attribution_data = process_fulfill_attribution_data(
-					attribution_data.as_ref(),
+					attribution_data,
 					&htlc.prev_hop.incoming_packet_shared_secret,
 					0,
 				);
@@ -8263,7 +8263,7 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
 		forwarded_htlc_value_msat: Option<u64>, skimmed_fee_msat: Option<u64>, from_onchain: bool,
 		startup_replay: bool, next_channel_counterparty_node_id: PublicKey,
 		next_channel_outpoint: OutPoint, next_channel_id: ChannelId,
-		next_user_channel_id: Option<u128>, attribution_data: Option<&AttributionData>,
+		next_user_channel_id: Option<u128>, attribution_data: Option<AttributionData>,
 		send_timestamp: Option<Duration>,
 	) {
 		match source {
@@ -9868,7 +9868,7 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
 	}
 
 	fn internal_update_fulfill_htlc(
-		&self, counterparty_node_id: &PublicKey, msg: &msgs::UpdateFulfillHTLC,
+		&self, counterparty_node_id: &PublicKey, msg: msgs::UpdateFulfillHTLC,
 	) -> Result<(), MsgHandleErrInternal> {
 		let funding_txo;
 		let next_user_channel_id;
@@ -9927,7 +9927,7 @@ This indicates a bug inside LDK. Please report this error at https://github.com/
 			funding_txo,
 			msg.channel_id,
 			Some(next_user_channel_id),
-			msg.attribution_data.as_ref(),
+			msg.attribution_data,
 			send_timestamp,
 		);
 
@@ -13489,7 +13489,7 @@ where
 		&self, counterparty_node_id: PublicKey, msg: msgs::UpdateFulfillHTLC,
 	) {
 		let _persistence_guard = PersistenceNotifierGuard::notify_on_drop(self);
-		let res = self.internal_update_fulfill_htlc(&counterparty_node_id, &msg);
+		let res = self.internal_update_fulfill_htlc(&counterparty_node_id, msg);
 		let _ = handle_error!(self, res, counterparty_node_id);
 	}
 

lightning/src/ln/onion_utils.rs

@@ -2871,12 +2871,10 @@ fn process_failure_packet(
 /// attribution data is passed in, a new `AttributionData` field is instantiated. It is needless to say that in that
 /// case the sender won't receive any hold times from nodes downstream of the current node.
 pub(crate) fn process_fulfill_attribution_data(
-	attribution_data: Option<&AttributionData>, shared_secret: &[u8], hold_time: u32,
+	attribution_data: Option<AttributionData>, shared_secret: &[u8], hold_time: u32,
 ) -> AttributionData {
 	let mut attribution_data =
-		attribution_data.map_or(AttributionData::new(), |attribution_data| {
-			let mut attribution_data = attribution_data.clone();
-
+		attribution_data.map_or(AttributionData::new(), |mut attribution_data| {
 			// Shift the existing attribution data to the right to make space for the new hold time and HMACs.
 			attribution_data.shift_right();