Merge pull request #2650 from TheBlueMatt/2023-10-make-clippy-shut-up

TheBlueMatt · web-flow · commit 6cafba9f5bc5 · 2023-10-12T20:44:46.000Z
Make clippy shut up about `PartialOrd` and `Ord` both impl'd
diff --git a/lightning-invoice/src/lib.rs b/lightning-invoice/src/lib.rs
@@ -504,7 +504,7 @@ pub struct Bolt11InvoiceSignature(pub RecoverableSignature);
 
 impl PartialOrd for Bolt11InvoiceSignature {
 	fn partial_cmp(&self, other: &Self) -> Option<Ordering> {
-		self.0.serialize_compact().1.partial_cmp(&other.0.serialize_compact().1)
+		Some(self.cmp(other))
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -504,7 +504,7 @@ pub struct Bolt11InvoiceSignature(pub RecoverableSignature);`
`504`	`504`
`505`	`505`	`impl PartialOrd for Bolt11InvoiceSignature {`
`506`	`506`	`fn partial_cmp(&self, other: &Self) -> Option<Ordering> {`
`507`		`- self.0.serialize_compact().1.partial_cmp(&other.0.serialize_compact().1)`
	`507`	`+ Some(self.cmp(other))`
`508`	`508`	`}`
`509`	`509`	`}`
`510`	`510`