fixup: Drop service set / list / remove events.

Service will no longer notify the user when it sets / lists / removes.
It will only notify when the user needs to do an HTTP call via SendWebhookNotification event

Author: martinsaposnic

lightning-liquidity/src/lsps5/event.rs

@@ -23,118 +23,6 @@ use super::msgs::WebhookNotification;
 /// An event which an bLIP-55 / LSPS5 server should take some action in response to.
 #[derive(Debug, Clone, PartialEq, Eq)]
 pub enum LSPS5ServiceEvent {
-	/// A webhook was registered by a client.
-	///
-	/// This event is triggered when a client successfully registers or updates a webhook
-	/// via [`lsps5.set_webhook`]. The LSP should store this webhook information for future
-	/// notifications to this client.
-	///
-	/// When this event occurs, the LSP should:
-	/// 1. Store the webhook information for the client
-	/// 2. If `no_change` is `false` (i.e., this is a new registration or an update with changes),
-	///    send an initial [`lsps5.webhook_registered`] notification to verify the webhook works.
-	///
-	/// [`lsps5.set_webhook`]: super::msgs::LSPS5Request::SetWebhook
-	/// [`lsps5.webhook_registered`]: super::msgs::WebhookNotificationMethod::LSPS5WebhookRegistered
-	WebhookRegistered {
-		/// Client node ID that registered the webhook.
-		counterparty_node_id: PublicKey,
-		/// App name provided by the client.
-		///
-		/// This app name is used to identify the webhook registration.
-		///
-		/// **Note**: Ensure the app name is valid and its length does not exceed [`MAX_APP_NAME_LENGTH`].
-		///
-		/// [`MAX_APP_NAME_LENGTH`]: super::msgs::MAX_APP_NAME_LENGTH
-		app_name: LSPS5AppName,
-		/// Webhook URL (HTTPS) to be contacted for notifying the client.
-		///
-		/// This URL is used by the LSP to send notifications.
-		///
-		/// **Note**: Ensure the URL is valid and its length does not exceed [`MAX_WEBHOOK_URL_LENGTH`].
-		/// Also ensure that the URL points to a public host.
-		///
-		/// [`MAX_WEBHOOK_URL_LENGTH`]: super::msgs::MAX_WEBHOOK_URL_LENGTH
-		url: LSPS5WebhookUrl,
-		/// The identifier of the issued bLIP-55 / LSPS5 webhook registration request.
-		///
-		/// This can be used to track which request this event corresponds to.
-		request_id: LSPSRequestId,
-		/// Whether this was a new registration or an update to existing one with no changes.
-		/// If false, a notification should be sent to the registered webhook.
-		no_change: bool,
-	},
-
-	/// Webhooks were listed for a client.
-	///
-	/// This event is triggered when a client successfully requests their registered webhooks
-	/// via [`lsps5.list_webhooks`]. The LSP has responded with the list of app names that
-	/// have registered webhooks for this client.
-	///
-	/// When this event occurs, it indicates that:
-	/// 1. The LSP has successfully fetched all registered webhook names for this client
-	/// 2. The LSP has sent a response containing the list and maximum allowed webhooks
-	/// 3. The client is now aware of all their currently registered webhooks
-	///
-	/// This event is primarily informational and doesn't typically require further action.
-	///
-	/// [`lsps5.list_webhooks`]: super::msgs::LSPS5Request::ListWebhooks
-	WebhooksListed {
-		/// Client node ID that requested their webhooks.
-		counterparty_node_id: PublicKey,
-		/// App names with registered webhooks for this client.
-		///
-		/// Each [`app_name`] in this list corresponds to a registered webhook.
-		///
-		/// [`app_name`]: super::msgs::LSPS5AppName
-		app_names: Vec<LSPS5AppName>,
-		/// The identifier of the issued bLIP-55 / LSPS5 webhook listing request.
-		///
-		/// This can be used to track which request this event corresponds to.
-		request_id: LSPSRequestId,
-		/// Maximum number of webhooks allowed by LSP per client.
-		///
-		/// This is the value defined in [`max_webhooks_per_client`] within the service configuration.
-		///
-		/// [`max_webhooks_per_client`]: super::service::LSPS5ServiceConfig::max_webhooks_per_client
-		max_webhooks: u32,
-	},
-
-	/// A webhook was removed by a client.
-	///
-	/// This event is triggered when a client successfully removes a webhook via
-	/// [`lsps5.remove_webhook`]. The LSP has deleted the specified webhook registration from
-	/// its storage and will no longer send notifications to this webhook URL.
-	///
-	/// When this event occurs, the LSP should:
-	/// 1. Confirm the webhook has been completely removed from all internal data structures
-	/// 2. If there are any pending notifications for this webhook, cancel them
-	/// 3. Update any related metrics or logs to reflect the webhook removal
-	///
-	/// Note that if a client attempts to remove a webhook that doesn't exist, a
-	/// [`LSPS5ProtocolError::AppNameNotFound`] error is returned instead, and this event
-	/// will not be triggered.
-	///
-	/// [`lsps5.remove_webhook`]: super::msgs::LSPS5Request::RemoveWebhook
-	/// [`LSPS5ProtocolError::AppNameNotFound`]: super::msgs::LSPS5ProtocolError::AppNameNotFound
-	WebhookRemoved {
-		/// Client node ID that removed the webhook.
-		counterparty_node_id: PublicKey,
-		/// App name that was removed.
-		///
-		/// This identifies the webhook that was removed.
-		///
-		/// **Note**: The [`app_name`] must have been previously registered via [`lsps5.set_webhook`].
-		///
-		/// [`app_name`]: super::msgs::LSPS5AppName
-		/// [`lsps5.set_webhook`]: super::msgs::LSPS5Request::SetWebhook
-		app_name: LSPS5AppName,
-		/// The identifier of the issued bLIP-55 / LSPS5 webhook removal request.
-		///
-		/// This can be used to track which request this event corresponds to.
-		request_id: LSPSRequestId,
-	},
-
 	/// A notification needs to be sent to a client's webhook.
 	///
 	/// This event is triggered when the LSP needs to notify a client about an event

lightning-liquidity/src/lsps5/service.rs

@@ -95,12 +95,9 @@ pub struct LSPS5ServiceConfig {
 /// # Core Responsibilities
 /// - Handle incoming JSON-RPC requests:
 ///   - `lsps5.set_webhook` -> insert or replace a webhook, enforce [`max_webhooks_per_client`],
-///     emit [`LSPS5ServiceEvent::WebhookRegistered`], and send an initial
-///     [`lsps5.webhook_registered`] notification if new or changed.
-///   - `lsps5.list_webhooks` -> return all registered [`app_name`]s via response and
-///     [`LSPS5ServiceEvent::WebhooksListed`].
-///   - `lsps5.remove_webhook` -> delete a named webhook or return [`app_name_not_found`]
-///     error, emitting [`LSPS5ServiceEvent::WebhookRemoved`].
+/// and send an initial [`lsps5.webhook_registered`] notification if new or changed.
+///   - `lsps5.list_webhooks` -> return all registered [`app_name`]s via response.
+///   - `lsps5.remove_webhook` -> delete a named webhook or return [`app_name_not_found`] error.
 /// - Prune stale webhooks after a client has no open channels and no activity for at least
 /// [`MIN_WEBHOOK_RETENTION_DAYS`].
 /// - Rate-limit repeat notifications of the same method to a client by
@@ -118,9 +115,6 @@ pub struct LSPS5ServiceConfig {
 ///
 /// [`bLIP-55 / LSPS5`]: https://github.com/lightning/blips/pull/55/files
 /// [`max_webhooks_per_client`]: super::service::LSPS5ServiceConfig::max_webhooks_per_client
-/// [`LSPS5ServiceEvent::WebhookRegistered`]: super::event::LSPS5ServiceEvent::WebhookRegistered
-/// [`LSPS5ServiceEvent::WebhooksListed`]: super::event::LSPS5ServiceEvent::WebhooksListed
-/// [`LSPS5ServiceEvent::WebhookRemoved`]: super::event::LSPS5ServiceEvent::WebhookRemoved
 /// [`app_name_not_found`]: super::msgs::LSPS5ProtocolError::AppNameNotFound
 /// [`notification_cooldown_hours`]: super::service::LSPS5ServiceConfig::notification_cooldown_hours
 /// [`WebhookNotification`]: super::msgs::WebhookNotification
@@ -182,7 +176,6 @@ where
 		&self, counterparty_node_id: PublicKey, request_id: LSPSRequestId,
 		params: SetWebhookRequest,
 	) -> Result<(), LightningError> {
-		let event_queue_notifier = self.event_queue.notifier();
 		self.check_prune_stale_webhooks();
 
 		let mut webhooks = self.webhooks.lock().unwrap();
@@ -228,19 +221,11 @@ where
 
 		client_webhooks.insert(params.app_name.clone(), stored_webhook);
 
-		event_queue_notifier.enqueue(LSPS5ServiceEvent::WebhookRegistered {
-			counterparty_node_id,
-			app_name: params.app_name.clone(),
-			url: params.webhook.clone(),
-			request_id: request_id.clone(),
-			no_change,
-		});
-
 		if !no_change {
 			self.send_webhook_registered_notification(
 				counterparty_node_id,
-				params.app_name.clone(),
-				params.webhook.clone(),
+				params.app_name,
+				params.webhook,
 			);
 		}
 
@@ -261,7 +246,6 @@ where
 		&self, counterparty_node_id: PublicKey, request_id: LSPSRequestId,
 		_params: ListWebhooksRequest,
 	) -> Result<(), LightningError> {
-		let event_queue_notifier = self.event_queue.notifier();
 		self.check_prune_stale_webhooks();
 
 		let webhooks = self.webhooks.lock().unwrap();
@@ -273,13 +257,6 @@ where
 
 		let max_webhooks = self.config.max_webhooks_per_client;
 
-		event_queue_notifier.enqueue(LSPS5ServiceEvent::WebhooksListed {
-			counterparty_node_id,
-			app_names: app_names.clone(),
-			max_webhooks,
-			request_id: request_id.clone(),
-		});
-
 		let response = ListWebhooksResponse { app_names, max_webhooks };
 		let msg = LSPS5Message::Response(request_id, LSPS5Response::ListWebhooks(response)).into();
 		self.pending_messages.enqueue(&counterparty_node_id, msg);
@@ -291,25 +268,17 @@ where
 		&self, counterparty_node_id: PublicKey, request_id: LSPSRequestId,
 		params: RemoveWebhookRequest,
 	) -> Result<(), LightningError> {
-		let event_queue_notifier = self.event_queue.notifier();
 		self.check_prune_stale_webhooks();
 
 		let mut webhooks = self.webhooks.lock().unwrap();
 
 		if let Some(client_webhooks) = webhooks.get_mut(&counterparty_node_id) {
 			if client_webhooks.remove(&params.app_name).is_some() {
 				let response = RemoveWebhookResponse {};
-				let msg = LSPS5Message::Response(
-					request_id.clone(),
-					LSPS5Response::RemoveWebhook(response),
-				)
-				.into();
+				let msg =
+					LSPS5Message::Response(request_id, LSPS5Response::RemoveWebhook(response))
+						.into();
 				self.pending_messages.enqueue(&counterparty_node_id, msg);
-				event_queue_notifier.enqueue(LSPS5ServiceEvent::WebhookRemoved {
-					counterparty_node_id,
-					app_name: params.app_name,
-					request_id,
-				});
 
 				return Ok(());
 			}