f Unify unnecessary NodeId::from_pubkey

Author: tnull

lightning/src/routing/router.rs

@@ -2102,13 +2102,14 @@ where L::Target: Logger {
 			.filter(|route| !route.0.is_empty())
 		{
 			let first_hop_in_route = &(route.0)[0];
+			let first_hop_src_id = NodeId::from_pubkey(&first_hop_in_route.src_node_id);
 			let have_hop_src_in_graph =
 				// Only add the hops in this route to our candidate set if either we are part of
 				// the first hop, we have a direct channel to the first hop, or the first hop is in
 				// the regular network graph.
-				our_node_id == NodeId::from_pubkey(&first_hop_in_route.src_node_id) ||
-				first_hop_targets.get(&NodeId::from_pubkey(&first_hop_in_route.src_node_id)).is_some() ||
-				network_nodes.get(&NodeId::from_pubkey(&first_hop_in_route.src_node_id)).is_some();
+				our_node_id == first_hop_src_id ||
+				first_hop_targets.get(&first_hop_src_id).is_some() ||
+				network_nodes.get(&first_hop_src_id).is_some();
 			if have_hop_src_in_graph {
 				// We start building the path from reverse, i.e., from payee
 				// to the first RouteHintHop in the path.