Skip to content

Commit 73e4bc8

Browse files
committed
Extract locks
1 parent 0b1978e commit 73e4bc8

File tree

1 file changed

+15
-24
lines changed

1 file changed

+15
-24
lines changed

lightning/src/ln/async_signer_tests.rs

Lines changed: 15 additions & 24 deletions
Original file line numberDiff line numberDiff line change
@@ -606,14 +606,11 @@ fn do_test_async_raa_peer_disconnect(
606606
if test_case == UnblockSignerAcrossDisconnectCase::BeforeMonitorRestored {
607607
dst.enable_channel_signer_op(&src.node.get_our_node_id(), &chan_id, block_raa_signer_op);
608608
chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
609-
let (latest_update, _) = dst
610-
.chain_monitor
611-
.latest_monitor_update_id
612-
.lock()
613-
.unwrap()
614-
.get(&chan_id)
615-
.unwrap()
616-
.clone();
609+
let latest_update;
610+
{
611+
let channel_map = dst.chain_monitor.latest_monitor_update_id.lock().unwrap();
612+
(latest_update, _) = channel_map.get(&chan_id).unwrap().clone();
613+
}
617614
dst.chain_monitor.chain_monitor.force_channel_monitor_updated(chan_id, latest_update);
618615
check_added_monitors!(dst, 0);
619616
}
@@ -772,14 +769,11 @@ fn do_test_async_commitment_signature_peer_disconnect(
772769
SignerOp::SignCounterpartyCommitment,
773770
);
774771
chanmon_cfgs[1].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
775-
let (latest_update, _) = dst
776-
.chain_monitor
777-
.latest_monitor_update_id
778-
.lock()
779-
.unwrap()
780-
.get(&chan_id)
781-
.unwrap()
782-
.clone();
772+
let latest_update;
773+
{
774+
let channel_map = dst.chain_monitor.latest_monitor_update_id.lock().unwrap();
775+
(latest_update, _) = channel_map.get(&chan_id).unwrap().clone();
776+
}
783777
dst.chain_monitor.chain_monitor.force_channel_monitor_updated(chan_id, latest_update);
784778
check_added_monitors!(dst, 0);
785779
}
@@ -924,14 +918,11 @@ fn do_test_async_commitment_signature_ordering(monitor_update_failure: bool) {
924918

925919
if monitor_update_failure {
926920
chanmon_cfgs[0].persister.set_update_ret(ChannelMonitorUpdateStatus::Completed);
927-
let (latest_update, _) = nodes[0]
928-
.chain_monitor
929-
.latest_monitor_update_id
930-
.lock()
931-
.unwrap()
932-
.get(&chan_id)
933-
.unwrap()
934-
.clone();
921+
let latest_update;
922+
{
923+
let channel_map = nodes[0].chain_monitor.latest_monitor_update_id.lock().unwrap();
924+
(latest_update, _) = channel_map.get(&chan_id).unwrap().clone();
925+
}
935926
nodes[0].chain_monitor.chain_monitor.force_channel_monitor_updated(chan_id, latest_update);
936927
check_added_monitors!(nodes[0], 0);
937928
}

0 commit comments

Comments
 (0)