fixup: clean up LSPS5 client time, URL and timestamp parsing

- Replace reqwest::Url with url::Url.
- Use SystemTime instead of Instant for cleanup handling.
- Remove unused update_config method.
- Update timestamp parsing in verify_notification_signature to use LSPSDateTime::from_str.

Author: martinsaposnic

lightning-liquidity/src/lsps5/client.rs

@@ -9,7 +9,7 @@
 //! Client implementation for LSPS5 webhook registration
 
 use crate::events::EventQueue;
-use crate::lsps0::ser::{LSPSMessage, LSPSProtocolMessageHandler, LSPSRequestId};
+use crate::lsps0::ser::{LSPSDateTime, LSPSMessage, LSPSProtocolMessageHandler, LSPSRequestId};
 use crate::lsps5::event::LSPS5ClientEvent;
 use crate::lsps5::msgs::{
 	LSPS5Message, LSPS5Request, LSPS5Response, ListWebhooksRequest, RemoveWebhookRequest, SetWebhookRequest, WebhookNotification,
@@ -23,19 +23,18 @@ use bitcoin::secp256k1::{PublicKey, Secp256k1};
 use lightning::ln::msgs::{ErrorAction, LightningError};
 
 use core::ops::Deref;
-use std::time::{Duration, SystemTime};
-use reqwest::Url;
-use std::sync::Arc;
-
-use std::collections::HashSet;
-use crate::sync::{Mutex, RwLock};
-use chrono::DateTime;
+use core::str::FromStr;
+#[cfg(feature = "std")]
+use std::time::{SystemTime, UNIX_EPOCH};
+use url::Url;
+use crate::sync::{Arc, Mutex, RwLock};
 
 use crate::prelude::{new_hash_map, HashMap, String};
 
 use super::{MAX_APP_NAME_LENGTH, MAX_WEBHOOK_URL_LENGTH};
 use lightning::sign::EntropySource;
 use lightning::util::logger::Level;
+use core::time::Duration;
 
 /// Default maximum age in seconds for cached responses (1 hour)
 pub const DEFAULT_RESPONSE_MAX_AGE_SECS: u64 = 3600;
@@ -60,25 +59,25 @@ struct PeerState {
     pending_list_webhooks_requests: HashSet<LSPSRequestId>,
     pending_remove_webhook_requests: HashMap<LSPSRequestId, String>, // RequestId -> app_name
     // Last cleanup time for garbage collection
-    last_cleanup: std::time::Instant,
+    last_cleanup: SystemTime,
 }
 
 impl PeerState {
     fn new() -> Self {
         Self {
             pending_set_webhook_requests: new_hash_map(),
-            pending_list_webhooks_requests: HashSet::new(),
+            pending_list_webhooks_requests: new_hash_set(),
             pending_remove_webhook_requests: new_hash_map(),
-            last_cleanup: std::time::Instant::now(),
+            last_cleanup: SystemTime::now(),
         }
     }
 
     /// Clean up expired responses based on max_age
     fn cleanup_expired_responses(&mut self) {
-        let now = std::time::Instant::now();
+        let now = SystemTime::now();
 
         // Only run cleanup once per minute to avoid excessive processing
-        if now.duration_since(self.last_cleanup) < Duration::from_secs(60) {
+        if now.duration_since(self.last_cleanup).unwrap() < Duration::from_secs(60) {
             return;
         }
 
@@ -124,11 +123,6 @@ where
         }
 	}
 
-    /// Update the client configuration
-    pub fn update_config(&mut self, config: LSPS5ClientConfig) {
-        self.config = config;
-    }
-
 	/// Register a webhook with the LSP
 	///
 	/// Implements the `lsps5.set_webhook` method from BLIP-55.
@@ -463,11 +457,11 @@ where
 		&self, counterparty_node_id: PublicKey, timestamp: &str, signature: &str, notification: &WebhookNotification,
 	) -> Result<bool, LightningError> {
 		// Check timestamp format
-		match DateTime::parse_from_rfc3339(timestamp) {
+		match LSPSDateTime::from_str(timestamp) {
 			Ok(timestamp_dt) => {
 				// Check timestamp is within 10 minutes of current time
 				let now = SystemTime::now()
-					.duration_since(std::time::UNIX_EPOCH)
+					.duration_since(UNIX_EPOCH)
 					.unwrap()
 					.as_secs() as i64;
 				let diff = (timestamp_dt.timestamp() - now).abs();
@@ -478,9 +472,9 @@ where
 					});
 				}
 			},
-			Err(e) => {
+			Err(_e) => {
 				return Err(LightningError {
-					err: format!("Invalid timestamp format: {} - {}", timestamp, e),
+					err: format!("Invalid timestamp format: {}", timestamp),
 					action: ErrorAction::IgnoreAndLog(Level::Error)
 				});
 			}
@@ -651,7 +645,6 @@ mod tests {
     use super::*;
     use bitcoin::secp256k1::SecretKey;
     use crate::{lsps0::ser::LSPSRequestId, lsps5::msgs::SetWebhookResponse, tests::utils::TestEntropy};
-    use std::time::Duration;
 
     fn setup_test_client() -> (LSPS5ClientHandler<Arc<TestEntropy>>, Arc<MessageQueue>, Arc<EventQueue>, PublicKey, PublicKey) {
         let test_entropy_source =Arc::new(TestEntropy {});
@@ -768,7 +761,7 @@ mod tests {
     fn test_cleanup_expired_responses() {
         // Create a mock PeerState with a very old cleanup time
         let mut peer_state = PeerState::new();
-        peer_state.last_cleanup = std::time::Instant::now() - Duration::from_secs(120); // 2 minutes old
+        peer_state.last_cleanup = SystemTime::now() - Duration::from_secs(120); // 2 minutes old
 
         // Add some pending requests
         let req_id = LSPSRequestId("test:request:id".to_string());
@@ -781,7 +774,7 @@ mod tests {
         peer_state.cleanup_expired_responses();
 
         // Verify last_cleanup was updated
-        assert!(peer_state.last_cleanup > std::time::Instant::now() - Duration::from_secs(10));
+        assert!(peer_state.last_cleanup > SystemTime::now() - Duration::from_secs(10));
     }
 
     #[test]