Skip to content

Commit 7ce1ee8

Browse files
committed
Move experimental HtlcHold bit from 1053 to 153
We prefer to stay within the 0-255 range reserved for bolts, as bits > 255 can be used by bLIPs.
1 parent 6008e04 commit 7ce1ee8

File tree

1 file changed

+20
-20
lines changed

1 file changed

+20
-20
lines changed

lightning-types/src/features.rs

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -171,9 +171,9 @@ mod sealed {
171171
,,,,,,,,,
172172
// Byte 17
173173
AnchorZeroFeeCommitmentsStaging,
174-
// Byte 18 - 130
175-
,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,
176-
// Byte 131
174+
// Byte 18
175+
,
176+
// Byte 19
177177
HtlcHold,
178178
]
179179
);
@@ -200,14 +200,14 @@ mod sealed {
200200
,,,,,,,,,
201201
// Byte 17
202202
AnchorZeroFeeCommitmentsStaging,
203-
// Byte 18 - 31
204-
,,,,,,,,,,,,,,
203+
// Byte 18
204+
,
205+
// Byte 19
206+
HtlcHold,
207+
// Byte 20 - 31
208+
,,,,,,,,,,,,
205209
// Byte 32
206210
DnsResolver,
207-
// Byte 33 - 130
208-
,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,,
209-
// Byte 131
210-
HtlcHold,
211211
]
212212
);
213213
define_context!(ChannelContext, []);
@@ -710,6 +710,17 @@ mod sealed {
710710
supports_anchor_zero_fee_commitments,
711711
requires_anchor_zero_fee_commitments
712712
);
713+
define_feature!(
714+
153, // The BOLTs PR uses feature bit 52/53, so add +100 for the experimental bit
715+
HtlcHold,
716+
[InitContext, NodeContext],
717+
"Feature flags for holding HTLCs and forwarding on receipt of an onion message",
718+
set_htlc_hold_optional,
719+
set_htlc_hold_required,
720+
clear_htlc_hold,
721+
supports_htlc_hold,
722+
requires_htlc_hold
723+
);
713724
define_feature!(
714725
259,
715726
DnsResolver,
@@ -721,17 +732,6 @@ mod sealed {
721732
supports_dns_resolution,
722733
requires_dns_resolution
723734
);
724-
define_feature!(
725-
1053, // The BOLTs PR uses feature bit 52/53, so add +1000 for the experimental bit
726-
HtlcHold,
727-
[InitContext, NodeContext],
728-
"Feature flags for holding HTLCs and forwarding on receipt of an onion message",
729-
set_htlc_hold_optional,
730-
set_htlc_hold_required,
731-
clear_htlc_hold,
732-
supports_htlc_hold,
733-
requires_htlc_hold
734-
);
735735

736736
// Note: update the module-level docs when a new feature bit is added!
737737

0 commit comments

Comments
 (0)