Remove dead code after deprecating HolderSignedTx

Author: wpaulino

lightning/src/chain/channelmonitor.rs

@@ -355,19 +355,6 @@ impl HolderCommitment {
 	}
 }
 
-impl HolderSignedTx {
-	fn non_dust_htlcs(&self) -> Vec<HTLCOutputInCommitment> {
-		self.htlc_outputs.iter().filter_map(|(htlc, _, _)| {
-			if htlc.transaction_output_index.is_some() {
-				Some(htlc.clone())
-			} else {
-				None
-			}
-		})
-		.collect()
-	}
-}
-
 /// We use this to track static counterparty commitment transaction data and to generate any
 /// justice or 2nd-stage preimage/timeout transactions.
 #[derive(Clone, PartialEq, Eq)]

lightning/src/ln/channelmanager.rs

@@ -718,18 +718,6 @@ impl HTLCSource {
 		}
 	}
 
-	#[cfg(debug_assertions)]
-	/// Checks whether this HTLCSource could possibly match the given HTLC output in a commitment
-	/// transaction. Useful to ensure different datastructures match up.
-	pub(crate) fn possibly_matches_output(&self, htlc: &super::chan_utils::HTLCOutputInCommitment) -> bool {
-		if let HTLCSource::OutboundRoute { first_hop_htlc_msat, .. } = self {
-			*first_hop_htlc_msat == htlc.amount_msat
-		} else {
-			// There's nothing we can check for forwarded HTLCs
-			true
-		}
-	}
-
 	/// Returns the CLTV expiry of the inbound HTLC (i.e. the source referred to by this object),
 	/// if the source was a forwarded HTLC and the HTLC was first forwarded on LDK 0.1.1 or later.
 	pub(crate) fn inbound_htlc_expiry(&self) -> Option<u32> {