Scale the success probability of channels without info down by 75%

If we are examining a channel for which we have no information at
all, we traditionally assume the HTLC success probability is
proportional to the channel's capacity. While this may be the case,
it is not the case that a tiny payment over a huge channel is
guaranteed to succeed, as we assume. Rather, the probability of
such success is likely closer to 50% than 100%.

Here we try to capture this by simply scaling the success
probability for channels where we have no information down
linearly. We pick 75% as the upper bound rather arbitrarily - while
50% may be more accurate, its possible it would lead to an
over-reliance on channels which we have paid through in the past,
which aren't necessarily always the best candidates.

Note that we only do this scaling for the historical bucket
tracker, as there we can be confident we've never seen a successful
HTLC completion on the given channel. If we were to apply the same
scaling to the simple liquidity bounds based scoring we'd penalize
channels we've never tried over those we've only ever fails to pay
over, which is obviously not a good outcome.

Author: TheBlueMatt

lightning/src/routing/scoring.rs

@@ -946,11 +946,21 @@ const BASE_AMOUNT_PENALTY_DIVISOR: u64 = 1 << 30;
 /// min_zero_implies_no_successes signals that an `amount_msat` of 0 means we've not (recently)
 /// seen an HTLC successfully complete over this channel.
 fn success_probability(
-	min_liquidity_msat: u64, amount_msat: u64, max_liquidity_msat: u64, _capacity_msat: u64,
-	_params: &ProbabilisticScoringFeeParameters, _min_zero_implies_no_successes: bool,
+	min_liquidity_msat: u64, amount_msat: u64, max_liquidity_msat: u64, capacity_msat: u64,
+	_params: &ProbabilisticScoringFeeParameters, min_zero_implies_no_successes: bool,
 ) -> (u64, u64) {
+	debug_assert!(min_liquidity_msat <= amount_msat);
+	debug_assert!(amount_msat < max_liquidity_msat);
+	debug_assert!(max_liquidity_msat <= capacity_msat);
+
 	let numerator = max_liquidity_msat - amount_msat;
-	let denominator = (max_liquidity_msat - min_liquidity_msat).saturating_add(1);
+	let mut denominator = (max_liquidity_msat - min_liquidity_msat).saturating_add(1);
+	if min_zero_implies_no_successes && min_liquidity_msat == 0 &&
+		numerator < u64::max_value() / 3 {
+		// If we have no knowledge of the channel, scale probability down by 75%
+		numerator = numerator * 3 / 4
+	}
+
 	(numerator, denominator)
 }