fixup! Store invoice HTLCSource::OutboundRoute and ensure correct hashing

Signed-off-by: Vincenzo Palazzo <[email protected]>

Author: vincenzopalazzo

lightning/src/ln/outbound_payment.rs

@@ -2033,7 +2033,7 @@ impl OutboundPayments {
 					payment_hash,
 					amount_msat,
 					fee_paid_msat,
-					bolt12_invoice: bolt12_invoice.clone(),
+					bolt12_invoice: bolt12_invoice,
 				}, Some(ev_completion_action.clone())));
 				payment.get_mut().mark_fulfilled();
 			}

lightning/src/offers/invoice.rs

@@ -1495,7 +1495,7 @@ pub(super) type BlindedPayInfoIter<'a> = core::iter::Map<
 >;
 
 /// Wire representation for an on-chain fallback address.
-#[derive(Clone, Debug, PartialEq, Hash)]
+#[derive(Clone, Debug, PartialEq)]
 pub(super) struct FallbackAddress {
 	pub(super) version: u8,
 	pub(super) program: Vec<u8>,

lightning/src/offers/nonce.rs

@@ -26,7 +26,7 @@ use crate::prelude::*;
 /// [`Offer::metadata`]: crate::offers::offer::Offer::metadata
 /// [`Offer::issuer_signing_pubkey`]: crate::offers::offer::Offer::issuer_signing_pubkey
 /// [`ExpandedKey`]: crate::ln::inbound_payment::ExpandedKey
-#[derive(Clone, Copy, Debug, Eq, PartialEq, Hash)]
+#[derive(Clone, Copy, Debug, Eq, PartialEq)]
 pub struct Nonce(pub(crate) [u8; Self::LENGTH]);
 
 impl Nonce {

lightning/src/offers/offer.rs

@@ -604,7 +604,7 @@ pub struct Offer {
 ///
 /// [`InvoiceRequest`]: crate::offers::invoice_request::InvoiceRequest
 /// [`Bolt12Invoice`]: crate::offers::invoice::Bolt12Invoice
-#[derive(Clone, Debug, Hash)]
+#[derive(Clone, Debug)]
 #[cfg_attr(test, derive(PartialEq))]
 pub(super) struct OfferContents {
 	chains: Option<Vec<ChainHash>>,
@@ -1059,7 +1059,7 @@ impl Writeable for OfferContents {
 
 /// The minimum amount required for an item in an [`Offer`], denominated in either bitcoin or
 /// another currency.
-#[derive(Clone, Copy, Debug, PartialEq, Hash)]
+#[derive(Clone, Copy, Debug, PartialEq)]
 pub enum Amount {
 	/// An amount of bitcoin.
 	Bitcoin {
@@ -1079,7 +1079,7 @@ pub enum Amount {
 pub type CurrencyCode = [u8; 3];
 
 /// Quantity of items supported by an [`Offer`].
-#[derive(Clone, Copy, Debug, PartialEq, Hash)]
+#[derive(Clone, Debug, PartialEq)]
 pub enum Quantity {
 	/// Up to a specific number of items (inclusive). Use when more than one item can be requested
 	/// but is limited (e.g., because of per customer or inventory limits).

lightning/src/offers/signer.rs

@@ -57,7 +57,7 @@ const ASYNC_PAYMENTS_HELD_HTLC_HMAC_INPUT: &[u8; 16] = &[9; 16];
 
 /// Message metadata which possibly is derived from [`MetadataMaterial`] such that it can be
 /// verified.
-#[derive(Clone, Hash)]
+#[derive(Clone)]
 pub(super) enum Metadata {
 	/// Metadata as parsed, supplied by the user, or derived from the message contents.
 	///
@@ -263,13 +263,6 @@ pub(super) struct MetadataMaterial {
 	encrypted_payment_id: Option<[u8; PaymentId::LENGTH]>,
 }
 
-impl core::hash::Hash for MetadataMaterial {
-	fn hash<H: core::hash::Hasher>(&self, state: &mut H) {
-		self.nonce.hash(state);
-		self.encrypted_payment_id.hash(state);
-	}
-}
-
 impl MetadataMaterial {
 	pub fn new(nonce: Nonce, expanded_key: &ExpandedKey, payment_id: Option<PaymentId>) -> Self {
 		// Encrypt payment_id

lightning/src/offers/static_invoice.rs

@@ -89,7 +89,7 @@ impl core::hash::Hash for StaticInvoice {
 /// The contents of a [`StaticInvoice`] for responding to an [`Offer`].
 ///
 /// [`Offer`]: crate::offers::offer::Offer
-#[derive(Clone, Debug, Hash)]
+#[derive(Clone, Debug)]
 struct InvoiceContents {
 	offer: OfferContents,
 	payment_paths: Vec<BlindedPaymentPath>,