Merge pull request #2746 from TheBlueMatt/2023-11-bitcoin-0.30-followups

Drop panic if rust-bitcoin adds a new Network

Author: tnull

lightning-invoice/src/lib.rs

@@ -407,7 +407,10 @@ impl From<Network> for Currency {
 			Network::Testnet => Currency::BitcoinTestnet,
 			Network::Regtest => Currency::Regtest,
 			Network::Signet => Currency::Signet,
-			_ => unreachable!(),
+			_ => {
+				debug_assert!(false, "Need to handle new rust-bitcoin network type");
+				Currency::Regtest
+			},
 		}
 	}
 }

lightning/src/offers/invoice.rs

@@ -926,20 +926,11 @@ impl InvoiceContents {
 			};
 
 			let program = &address.program;
-			if program.len() < 2 || program.len() > 40 {
-				return None;
-			}
-
 			let witness_program = match WitnessProgram::new(version, program.clone()) {
 				Ok(witness_program) => witness_program,
 				Err(_) => return None,
 			};
-			let address = Address::new(network, Payload::WitnessProgram(witness_program));
-			if !address.is_spend_standard() && version == WitnessVersion::V0 {
-				return None;
-			}
-
-			Some(address)
+			Some(Address::new(network, Payload::WitnessProgram(witness_program)))
 		};
 
 		self.fields().fallbacks