f use a var for if we're done

Author: TheBlueMatt

lightning/src/routing/scoring.rs

@@ -1143,14 +1143,15 @@ impl<G: Deref<Target = NetworkGraph<L>>, L: Deref, T: Time> Score for Probabilis
 				.get(&hop.short_channel_id)
 				.and_then(|channel| channel.as_directed_to(&target));
 
-			if hop.short_channel_id == short_channel_id && hop_idx == 0 {
+			let at_failed_channel = hop.short_channel_id == short_channel_id;
+			if at_failed_channel && hop_idx == 0 {
 				log_warn!(self.logger, "Payment failed at the first hop - we do not attempt to learn channel info in such cases as we can directly observe local state.\n\tBecause we know the local state, we should generally not see failures here - this may be an indication that your channel peer on channel {} is broken and you may wish to close the channel.", hop.short_channel_id);
 			}
 
 			// Only score announced channels.
 			if let Some((channel, source)) = channel_directed_from_source {
 				let capacity_msat = channel.effective_capacity().as_msat();
-				if hop.short_channel_id == short_channel_id {
+				if at_failed_channel {
 					self.channel_liquidities
 						.entry(hop.short_channel_id)
 						.or_insert_with(ChannelLiquidity::new)
@@ -1167,7 +1168,7 @@ impl<G: Deref<Target = NetworkGraph<L>>, L: Deref, T: Time> Score for Probabilis
 				log_debug!(self.logger, "Not able to penalize channel with SCID {} as we do not have graph info for it (likely a route-hint last-hop).",
 					hop.short_channel_id);
 			}
-			if hop.short_channel_id == short_channel_id { break; }
+			if at_failed_channel { break; }
 		}
 	}