Make the custom message traits cloneable as they're deep in nested structs

Author: TheBlueMatt

fuzz/src/onion_message.rs

@@ -164,7 +164,7 @@ impl AsyncPaymentsMessageHandler for TestAsyncPaymentsMessageHandler {
 	fn handle_release_held_htlc(&self, _message: ReleaseHeldHtlc, _context: AsyncPaymentsContext) {}
 }
 
-#[derive(Debug)]
+#[derive(Clone, Debug)]
 struct TestCustomMessage {}
 
 const CUSTOM_MESSAGE_TYPE: u64 = 4242;

lightning/src/ln/wire.rs

@@ -46,9 +46,9 @@ impl<T> TestEq for T {}
 /// A Lightning message returned by [`read`] when decoding bytes received over the wire. Each
 /// variant contains a message from [`msgs`] or otherwise the message type if unknown.
 #[allow(missing_docs)]
-#[derive(Debug)]
+#[derive(Clone, Debug)]
 #[cfg_attr(any(test, feature = "_test_utils"), derive(PartialEq))]
-pub(crate) enum Message<T: core::fmt::Debug + Type + TestEq> {
+pub(crate) enum Message<T> where T: Clone + core::fmt::Debug + Type + TestEq {
 	Init(msgs::Init),
 	Error(msgs::ErrorMessage),
 	Warning(msgs::WarningMessage),
@@ -452,13 +452,13 @@ pub(crate) use self::encode::Encode;
 /// Defines a type identifier for sending messages over the wire.
 ///
 /// Messages implementing this trait specify a type and must be [`Writeable`].
-pub trait Type: core::fmt::Debug + Writeable {
+pub trait Type: core::fmt::Debug + Writeable + Clone {
 	/// Returns the type identifying the message payload.
 	fn type_id(&self) -> u16;
 }
 
 #[cfg(test)]
-pub trait Type: core::fmt::Debug + Writeable + PartialEq {
+pub trait Type: core::fmt::Debug + Writeable + Clone + PartialEq {
 	fn type_id(&self) -> u16;
 }
 
@@ -470,14 +470,14 @@ impl Type for () {
 }
 
 #[cfg(test)]
-impl<T: Encode + Writeable + core::fmt::Debug + PartialEq> Type for T {
+impl<T: Encode + Writeable + core::fmt::Debug + Clone + PartialEq> Type for T {
 	fn type_id(&self) -> u16 {
 		T::TYPE
 	}
 }
 
 #[cfg(not(test))]
-impl<T: Encode + core::fmt::Debug + Writeable> Type for T {
+impl<T: Encode + core::fmt::Debug + Writeable + Clone> Type for T {
 	fn type_id(&self) -> u16 {
 		T::TYPE
 	}
@@ -882,7 +882,7 @@ mod tests {
 		}
 	}
 
-	#[derive(Eq, PartialEq, Debug)]
+	#[derive(Clone, Eq, PartialEq, Debug)]
 	struct TestCustomMessage {}
 
 	const CUSTOM_MESSAGE_TYPE: u16 = 9000;

lightning/src/onion_message/functional_tests.rs

@@ -898,7 +898,7 @@ fn reply_path() {
 fn invalid_custom_message_type() {
 	let nodes = create_nodes(2);
 
-	#[derive(Debug)]
+	#[derive(Debug, Clone)]
 	struct InvalidCustomMessage {}
 	impl OnionMessageContents for InvalidCustomMessage {
 		fn tlv_type(&self) -> u64 {

lightning/src/onion_message/messenger.rs

@@ -243,7 +243,7 @@ where
 ///     &custom_message_handler,
 /// );
 ///
-/// # #[derive(Debug)]
+/// # #[derive(Clone, Debug)]
 /// # struct YourCustomMessage {}
 /// impl Writeable for YourCustomMessage {
 /// 	fn write<W: Writer>(&self, w: &mut W) -> Result<(), io::Error> {

lightning/src/onion_message/packet.rs

@@ -189,7 +189,7 @@ impl<T: OnionMessageContents> Writeable for ParsedOnionMessageContents<T> {
 }
 
 /// The contents of an onion message.
-pub trait OnionMessageContents: Writeable + core::fmt::Debug {
+pub trait OnionMessageContents: Writeable + core::fmt::Debug + Clone {
 	/// Returns the TLV type identifying the message contents. MUST be >= 64.
 	fn tlv_type(&self) -> u64;