Replace insert_outbound_channel with PeerState::new_order

.. requiring less access to internals

Author: tnull

lightning-liquidity/src/lsps1/peer_state.rs

@@ -21,9 +21,12 @@ pub(super) struct PeerState {
 }
 
 impl PeerState {
-	pub(super) fn insert_outbound_channel(
-		&mut self, order_id: LSPS1OrderId, channel: OutboundCRChannel,
+	pub(super) fn new_order(
+		&mut self, order_id: LSPS1OrderId, order_params: LSPS1OrderParams,
+		created_at: LSPSDateTime, payment_details: LSPS1PaymentInfo,
 	) {
+		let channel = OutboundCRChannel::new(order_params, created_at, payment_details);
+
 		self.outbound_channels_by_order_id.insert(order_id, channel);
 	}
 }

lightning-liquidity/src/lsps1/service.rs

@@ -20,7 +20,7 @@ use super::msgs::{
 	LSPS1OrderState, LSPS1PaymentInfo, LSPS1Request, LSPS1Response,
 	LSPS1_CREATE_ORDER_REQUEST_ORDER_MISMATCH_ERROR_CODE,
 };
-use super::peer_state::{OutboundCRChannel, PeerState};
+use super::peer_state::PeerState;
 use crate::message_queue::MessageQueue;
 
 use crate::events::EventQueue;
@@ -195,14 +195,14 @@ where
 				match peer_state_lock.pending_requests.remove(&request_id) {
 					Some(LSPS1Request::CreateOrder(params)) => {
 						let order_id = self.generate_order_id();
-						let channel = OutboundCRChannel::new(
+
+						peer_state_lock.new_order(
+							order_id.clone(),
 							params.order.clone(),
 							created_at,
 							payment.clone(),
 						);
 
-						peer_state_lock.insert_outbound_channel(order_id.clone(), channel);
-
 						let response = LSPS1Response::CreateOrder(LSPS1CreateOrderResponse {
 							order: params.order,
 							order_id,