Minor review fixes

Author: optout21

lightning-invoice/src/de.rs

@@ -71,10 +71,8 @@ impl FromBase32 for PaymentSecret {
 				"PaymentSecret::from_base32()".into(),
 			));
 		}
-		let data_bytes = Vec::<u8>::from_base32(field_data)?;
-		let mut payment_secret = [0; 32];
-		payment_secret.copy_from_slice(&data_bytes);
-		Ok(PaymentSecret(payment_secret))
+		let data_bytes = <[u8; 32]>::from_base32(field_data)?;
+		Ok(PaymentSecret(data_bytes))
 	}
 }
 

lightning-invoice/src/ser.rs

@@ -128,8 +128,8 @@ impl Base32Iterable for Bolt11InvoiceFeatures {
 
 impl Base32Len for Bolt11InvoiceFeatures {
 	fn base32_len(&self) -> usize {
-		// Here we actually do the conversion
-		self.fe_iter().collect::<Vec<Fe32>>().len()
+		// Here we perform the real conversion, due to trimming it's hard to estimate
+		self.fe_iter().count()
 	}
 }