When processing pending htlcs, abandon outbounds that are not retryable

Author: valentinewallace

lightning/src/ln/outbound_payment.rs

@@ -536,6 +536,24 @@ impl OutboundPayments {
 				}
 			} else { break }
 		}
+
+		let mut outbounds = self.pending_outbound_payments.lock().unwrap();
+		outbounds.retain(|pmt_id, pmt| {
+			let mut retain = true;
+			let auto_retryable = pmt.is_auto_retryable_now();
+			if let PendingOutboundPayment::Retryable { pending_amt_msat, total_msat, .. } = pmt {
+				if pending_amt_msat < total_msat {
+					if !auto_retryable && pmt.mark_abandoned().is_ok() && pmt.remaining_parts() == 0 {
+						pending_events.lock().unwrap().push(events::Event::PaymentFailed {
+							payment_id: *pmt_id,
+							payment_hash: pmt.payment_hash().expect("PendingOutboundPayments::Retryable always has a payment hash set"),
+						});
+						retain = false;
+					}
+				}
+			}
+			retain
+		});
 	}
 
 	/// Will return `Ok(())` iff at least one HTLC is sent for the payment.

lightning/src/ln/payment_tests.rs

@@ -1733,7 +1733,6 @@ fn do_automatic_retries(test: AutoRetry) {
 			let mut msg_events = nodes[0].node.get_and_clear_pending_msg_events();
 			assert_eq!(msg_events.len(), 0);
 
-			nodes[0].node.abandon_payment(PaymentId(payment_hash.0));
 			let mut events = nodes[0].node.get_and_clear_pending_events();
 			assert_eq!(events.len(), 1);
 			match events[0] {
@@ -1768,7 +1767,6 @@ fn do_automatic_retries(test: AutoRetry) {
 		let mut msg_events = nodes[0].node.get_and_clear_pending_msg_events();
 		assert_eq!(msg_events.len(), 0);
 
-		nodes[0].node.abandon_payment(PaymentId(payment_hash.0));
 		let mut events = nodes[0].node.get_and_clear_pending_events();
 		assert_eq!(events.len(), 1);
 		match events[0] {