Add some bech32 serial/deserial tests

Author: optout21

lightning-invoice/tests/ser_de.rs

@@ -475,16 +475,63 @@ fn invoice_features_encoding() {
 	assert_eq!(features, features_deserialized);
 }
 
+use core::fmt::Debug;
+
+/// Test base32 encode and decode
+fn ser_de_test<T>(o: T, expected_str: &str) where T: ToBase32 + FromBase32 + Eq + Debug, T::Err: Debug {
+	let serialized_32 = o.to_base32();
+	assert_eq!(serialized_32.len(), expected_str.len());
+
+	let serialized_str = serialized_32.iter().map(|f| f.to_char()).collect::<String>();
+	assert_eq!(serialized_str, expected_str);
+
+	// deserialize back
+	let o2 = T::from_base32(&serialized_32).unwrap();
+	assert_eq!(o, o2);
+}
+
+/// Test base32 encode and decode, and also length hint
+fn ser_de_test_len<T>(o: T, expected_str: &str, opt_expected_len_hint: Option<usize>) where T: ToBase32 + FromBase32 + Base32Len + Eq + Debug, T::Err: Debug {
+	let expected_len_hint = opt_expected_len_hint.unwrap_or(expected_str.len());
+	assert_eq!(o.base32_len(), expected_len_hint);
+
+	ser_de_test(o, expected_str)
+}
+
+#[test]
+fn vec_u8() {
+	let v = vec![0, 1, 2, 3, 4, 5, 6, 7, 8, 9];
+	ser_de_test_len(v, "qqqsyqcyq5rqwzqf", Some(17)); // 16 or 17 ?
+}
+
+#[test]
+fn payment_secret() {
+	let payment_secret = PaymentSecret([7; 32]);
+	ser_de_test_len(payment_secret, "qurswpc8qurswpc8qurswpc8qurswpc8qurswpc8qurswpc8qurs", None);
+}
+
+#[test]
+fn raw_data_part() {
+	use crate::TaggedField::PaymentHash;
+
+	let raw_data_part = RawDataPart {
+		timestamp: PositiveTimestamp::from_unix_timestamp(10000).unwrap(),
+		tagged_fields: vec ! [
+			PaymentHash(Sha256(sha256::Hash::from_str(
+				"0001020304050607080900010203040506070809000102030405060708090102"
+			).unwrap())).into(),
+		],
+	};
+	ser_de_test(raw_data_part, "qqqqfcspp5qqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqqqsyqcyq5rqwzqfqypq");
+}
+
 #[test]
-fn payeepubkey_ser_de() {
+fn payeepubkey() {
 	use bitcoin::key::Secp256k1;
 	use bitcoin::secp256k1::{PublicKey, SecretKey};
 
 	let secp = Secp256k1::new();
 	let dummy_secret_key = SecretKey::from_slice(&[1; 32]).unwrap();
 	let payee_pub_key = PayeePubKey(PublicKey::from_secret_key(&secp, &dummy_secret_key));
-	let serialized32 = payee_pub_key.to_base32();
-	assert_eq!(serialized32.len(), 53);
-	let payee_pub_key2 = PayeePubKey::from_base32(&serialized32).unwrap();
-	assert_eq!(payee_pub_key, payee_pub_key2);
+	ser_de_test_len(payee_pub_key, "qvdcf32k0vfxgsyet5ldt246q4jaw8scx3sysx0lnstlt6w4m5rc7", None);
 }