Merge pull request #2055 from TheBlueMatt/2023-02-fning-msrv

Remove the lightning-transaction-sync MSRV

Author: TheBlueMatt

.github/workflows/build.yml

@@ -15,9 +15,7 @@ jobs:
                      # 1.45.2 is MSRV for lightning-net-tokio, lightning-block-sync, lightning-background-processor
                      1.45.2,
                      # 1.47.0 will be the MSRV for no-std builds using hashbrown once core2 is updated
-                     1.47.0,
-                     # 1.59.0 is the MSRV for lightning-transaction-sync
-                     1.59.0]
+                     1.47.0]
         include:
           - toolchain: stable
             build-net-tokio: true
@@ -73,11 +71,6 @@ jobs:
             build-futures: true
             build-no-std: true
             build-tx-sync: false
-          - toolchain: 1.59.0
-            build-net-tokio: false
-            build-no-std: false
-            build-futures: false
-            build-tx-sync: true
     runs-on: ${{ matrix.platform }}
     steps:
       - name: Checkout source code
@@ -93,10 +86,10 @@ jobs:
         run: cargo update -p tokio --precise "1.14.0" --verbose
         env:
           CARGO_NET_GIT_FETCH_WITH_CLI: "true"
-      - name: Build on Rust ${{ matrix.toolchain }} with net-tokio and tx-sync
-        if: "matrix.build-net-tokio && !matrix.coverage && matrix.build-tx-sync"
+      - name: Build on Rust ${{ matrix.toolchain }} with net-tokio
+        if: "matrix.build-net-tokio && !matrix.coverage"
         run: cargo build --verbose --color always
-      - name: Build on Rust ${{ matrix.toolchain }} with net-tokio, tx-sync, and full code-linking for coverage generation
+      - name: Build on Rust ${{ matrix.toolchain }} with net-tokio, and full code-linking for coverage generation
         if: matrix.coverage
         run: RUSTFLAGS="-C link-dead-code" cargo build --verbose --color always
       - name: Build on Rust ${{ matrix.toolchain }}
@@ -151,9 +144,9 @@ jobs:
         run: |
           cd lightning && cargo test --verbose --color always --features backtrace
       - name: Test on Rust ${{ matrix.toolchain }} with net-tokio
-        if: "matrix.build-net-tokio && !matrix.coverage && matrix.build-tx-sync"
+        if: "matrix.build-net-tokio && !matrix.coverage"
         run: cargo test --verbose --color always
-      - name: Test on Rust ${{ matrix.toolchain }} with net-tokio, tx-sync, and full code-linking for coverage generation
+      - name: Test on Rust ${{ matrix.toolchain }} with net-tokio, and full code-linking for coverage generation
         if: matrix.coverage
         run: RUSTFLAGS="-C link-dead-code" cargo test --verbose --color always
       - name: Test no-std builds on Rust ${{ matrix.toolchain }}

Cargo.toml

@@ -3,7 +3,6 @@
 members = [
     "lightning",
     "lightning-block-sync",
-    "lightning-transaction-sync",
     "lightning-invoice",
     "lightning-net-tokio",
     "lightning-persister",
@@ -13,6 +12,7 @@ members = [
 
 exclude = [
     "lightning-custom-message",
+    "lightning-transaction-sync",
     "no-std-check",
 ]
 

lightning/src/ln/outbound_payment.rs

@@ -1459,8 +1459,7 @@ mod tests {
 	fn initial_send_payment_path_failed_evs() {
 		let outbound_payments = OutboundPayments::new();
 		let logger = test_utils::TestLogger::new();
-		let genesis_hash = genesis_block(Network::Testnet).header.block_hash();
-		let network_graph = Arc::new(NetworkGraph::new(genesis_hash, &logger));
+		let network_graph = Arc::new(NetworkGraph::new(Network::Testnet, &logger));
 		let scorer = Mutex::new(test_utils::TestScorer::new());
 		let router = test_utils::TestRouter::new(network_graph, &scorer);
 		let secp_ctx = Secp256k1::new();