fixup! Attributable failures pre-factor

Author: joostjager

lightning/src/ln/channel.rs

@@ -6070,7 +6070,7 @@ impl<SP: Deref> FundedChannel<SP> where
 										require_commitment = true;
 										match fail_msg {
 											HTLCFailureMsg::Relay(msg) => {
-												htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay((&msg).into()));
+												htlc.state = InboundHTLCState::LocalRemoved(InboundHTLCRemovalReason::FailRelay(msg.clone().into()));
 												update_fail_htlcs.push(msg)
 											},
 											HTLCFailureMsg::Malformed(msg) => {

lightning/src/ln/channelmanager.rs

@@ -4440,7 +4440,7 @@ where
 		HTLCFailureMsg::Relay(msgs::UpdateFailHTLC {
 			channel_id: msg.channel_id,
 			htlc_id: msg.htlc_id,
-			reason: failure.data.clone(),
+			reason: failure.data,
 		})
 	}
 
@@ -5824,7 +5824,7 @@ where
 				let failure = match htlc_fail {
 					HTLCFailureMsg::Relay(fail_htlc) => HTLCForwardInfo::FailHTLC {
 						htlc_id: fail_htlc.htlc_id,
-						err_packet: (&fail_htlc).into(),
+						err_packet: fail_htlc.into(),
 					},
 					HTLCFailureMsg::Malformed(fail_malformed_htlc) => HTLCForwardInfo::FailMalformedHTLC {
 						htlc_id: fail_malformed_htlc.htlc_id,

lightning/src/ln/msgs.rs

@@ -2355,10 +2355,10 @@ pub(crate) struct OnionErrorPacket {
 	pub(crate) data: Vec<u8>,
 }
 
-impl From<&UpdateFailHTLC> for OnionErrorPacket {
-	fn from(msg: &UpdateFailHTLC) -> Self {
+impl From<UpdateFailHTLC> for OnionErrorPacket {
+	fn from(msg: UpdateFailHTLC) -> Self {
 		OnionErrorPacket {
-			data: msg.reason.clone(),
+			data: msg.reason,
 		}
 	}
 }