wip. rebase needed

Author: martinsaposnic

lightning-liquidity/src/lsps5/msgs.rs

@@ -157,11 +157,6 @@ impl LSPS5AppName {
 	pub fn as_str(&self) -> &str {
 		self
 	}
-
-	/// Convert the app name to a string
-	pub fn to_string(&self) -> String {
-		self.0 .0.clone()
-	}
 }
 
 impl Deref for LSPS5AppName {
@@ -244,11 +239,6 @@ impl LSPS5WebhookUrl {
 	pub fn as_str(&self) -> &str {
 		self
 	}
-
-	/// Convert the webhook URL to a string
-	pub fn to_string(&self) -> String {
-		self.0.url().to_string()
-	}
 }
 
 impl Deref for LSPS5WebhookUrl {

lightning-liquidity/src/lsps5/service.rs

@@ -147,8 +147,9 @@ impl LSPS5ServiceHandler {
 		client_has_open_channel: Box<dyn Fn(&PublicKey) -> bool>, config: LSPS5ServiceConfig,
 		time_provider: Option<Arc<dyn TimeProvider>>,
 	) -> Option<Self> {
-		let Some(time_provider) = time_provider else {
-			return None;
+		let time_provider = match time_provider {
+			Some(provider) => provider,
+			None => return None,
 		};
 		Some(Self {
 			config,

lightning-liquidity/src/lsps5/url_utils.rs

@@ -43,11 +43,10 @@ impl LSPSUrl {
 			return Err(());
 		}
 
-		let host_section =
-			remainder.split(|c| c == '/' || c == '?' || c == '#').next().ok_or_else(|| ())?;
+		let host_section = remainder.split(['/', '?', '#']).next().ok_or_else(|| ())?;
 
 		let host_without_auth =
-			host_section.split('@').last().filter(|s| !s.is_empty()).ok_or_else(|| ())?;
+			host_section.split('@').next_back().filter(|s| !s.is_empty()).ok_or_else(|| ())?;
 
 		if host_without_auth.is_empty() {
 			return Err(());

lightning-liquidity/src/manager.rs

@@ -186,7 +186,7 @@ where {
 					);
 
 					#[cfg(not(feature = "time"))]
-					return LSPS5ClientHandler::_new_with_custom_time_provider(
+					return LSPS5ClientHandler::new_with_custom_time_provider(
 						entropy_source.clone(),
 						Arc::clone(&pending_messages),
 						Arc::clone(&pending_events),
@@ -231,7 +231,7 @@ where {
 					);
 
 					#[cfg(not(feature = "time"))]
-					return LSPS5ServiceHandler::_new_with_custom_time_provider(
+					return LSPS5ServiceHandler::new_with_custom_time_provider(
 						Arc::clone(&pending_events),
 						Arc::clone(&pending_messages),
 						client_has_open_channels,