Merge pull request #3963 from martinsaposnic/lsps5-small-followups

LSPS5 - small follow ups

Author: TheBlueMatt

lightning-liquidity/src/lsps5/client.rs

@@ -43,7 +43,7 @@ pub const DEFAULT_RESPONSE_MAX_AGE_SECS: u64 = 3600;
 #[derive(Debug, Clone)]
 /// Configuration for the LSPS5 client
 pub struct LSPS5ClientConfig {
-	/// Maximum age in seconds for cached responses (default: 3600 - 1 hour).
+	/// Maximum age in seconds for cached responses (default: [`DEFAULT_RESPONSE_MAX_AGE_SECS`]).
 	pub response_max_age_secs: Duration,
 }
 

lightning-liquidity/src/lsps5/service.rs

@@ -339,7 +339,7 @@ where
 	/// [`WebhookNotificationMethod::LSPS5PaymentIncoming`]: super::msgs::WebhookNotificationMethod::LSPS5PaymentIncoming
 	pub fn notify_payment_incoming(&self, client_id: PublicKey) -> Result<(), LSPS5ProtocolError> {
 		let notification = WebhookNotification::payment_incoming();
-		self.broadcast_notification(client_id, notification)
+		self.send_notifications_to_client_webhooks(client_id, notification)
 	}
 
 	/// Notify that an HTLC or other time-bound contract is expiring soon.
@@ -359,7 +359,7 @@ where
 		&self, client_id: PublicKey, timeout: u32,
 	) -> Result<(), LSPS5ProtocolError> {
 		let notification = WebhookNotification::expiry_soon(timeout);
-		self.broadcast_notification(client_id, notification)
+		self.send_notifications_to_client_webhooks(client_id, notification)
 	}
 
 	/// Notify that the LSP intends to manage liquidity (e.g. close or splice) on client channels.
@@ -376,7 +376,7 @@ where
 		&self, client_id: PublicKey,
 	) -> Result<(), LSPS5ProtocolError> {
 		let notification = WebhookNotification::liquidity_management_request();
-		self.broadcast_notification(client_id, notification)
+		self.send_notifications_to_client_webhooks(client_id, notification)
 	}
 
 	/// Notify that the client has one or more pending BOLT Onion Messages.
@@ -393,10 +393,10 @@ where
 		&self, client_id: PublicKey,
 	) -> Result<(), LSPS5ProtocolError> {
 		let notification = WebhookNotification::onion_message_incoming();
-		self.broadcast_notification(client_id, notification)
+		self.send_notifications_to_client_webhooks(client_id, notification)
 	}
 
-	fn broadcast_notification(
+	fn send_notifications_to_client_webhooks(
 		&self, client_id: PublicKey, notification: WebhookNotification,
 	) -> Result<(), LSPS5ProtocolError> {
 		let mut webhooks = self.webhooks.lock().unwrap();

lightning-liquidity/src/manager.rs

@@ -299,7 +299,7 @@ where
 					channel_manager.clone(),
 					node_signer,
 					config.clone(),
-					time_provider.clone(),
+					time_provider,
 				)
 			})
 		});