f How I learned to love the unwrap

tnull · tnull · commit bf68510104fc · 2025-07-22T15:18:48.000+02:00
diff --git a/lightning-background-processor/src/fwd_batch.rs b/lightning-background-processor/src/fwd_batch.rs
@@ -31,13 +31,12 @@ impl BatchDelay {
 }
 
 fn rand_batch_delay_millis() -> u16 {
-	const FALLBACK_DELAY: u16 = 50;
 	const USIZE_LEN: usize = core::mem::size_of::<usize>();
 	let mut random_bytes = [0u8; USIZE_LEN];
 	possiblyrandom::getpossiblyrandom(&mut random_bytes);
 
 	let index = usize::from_be_bytes(random_bytes) % FWD_DELAYS_MILLIS.len();
-	*FWD_DELAYS_MILLIS.get(index).unwrap_or(&FALLBACK_DELAY)
+	FWD_DELAYS_MILLIS[index]
 }
 
 // An array of potential forwarding delays (log-normal distribution, 10000 samples, mean = 50, sd = 0.5), generated via the following R-script:

Original file line number	Diff line number	Diff line change
`@@ -31,13 +31,12 @@ impl BatchDelay {`
`31`	`31`	`}`
`32`	`32`
`33`	`33`	`fn rand_batch_delay_millis() -> u16 {`
`34`		`- const FALLBACK_DELAY: u16 = 50;`
`35`	`34`	`const USIZE_LEN: usize = core::mem::size_of::<usize>();`
`36`	`35`	`let mut random_bytes = [0u8; USIZE_LEN];`
`37`	`36`	`possiblyrandom::getpossiblyrandom(&mut random_bytes);`
`38`	`37`
`39`	`38`	`let index = usize::from_be_bytes(random_bytes) % FWD_DELAYS_MILLIS.len();`
`40`		`- *FWD_DELAYS_MILLIS.get(index).unwrap_or(&FALLBACK_DELAY)`
	`39`	`+ FWD_DELAYS_MILLIS[index]`
`41`	`40`	`}`
`42`	`41`
`43`	`42`	`// An array of potential forwarding delays (log-normal distribution, 10000 samples, mean = 50, sd = 0.5), generated via the following R-script:`