f - expand tests

Author: jkczyz

lightning/src/ln/offers_tests.rs

@@ -1120,12 +1120,20 @@ fn fails_authentication_when_handling_invoice_request() {
 		assert_eq!(path.introduction_node, IntroductionNode::NodeId(bob_id));
 	}
 
+	let invalid_path = alice.node
+		.create_offer_builder(None)
+		.unwrap()
+		.build().unwrap()
+		.paths().first().unwrap()
+		.clone();
+	assert_eq!(invalid_path.introduction_node, IntroductionNode::NodeId(bob_id));
+
+	// Send the invoice request directly to Alice instead of using a blinded path.
 	let payment_id = PaymentId([1; 32]);
 	david.node.pay_for_offer(&offer, None, None, None, payment_id, Retry::Attempts(0), None)
 		.unwrap();
 	expect_recent_payment!(david, RecentPaymentDetails::AwaitingInvoice, payment_id);
 
-	// Send the invoice request directly to Alice instead of using a blinded path.
 	connect_peers(david, alice);
 	#[cfg(not(c_bindings))] {
 		david.node.pending_offers_messages.lock().unwrap().first_mut().unwrap().destination =
@@ -1145,6 +1153,39 @@ fn fails_authentication_when_handling_invoice_request() {
 	assert_eq!(reply_path.introduction_node, IntroductionNode::NodeId(charlie_id));
 
 	assert_eq!(alice.onion_messenger.next_onion_message_for_peer(charlie_id), None);
+
+	david.node.abandon_payment(payment_id);
+	get_event!(david, Event::InvoiceRequestFailed);
+
+	// Send the invoice request to Alice using an invalid blinded path.
+	let payment_id = PaymentId([2; 32]);
+	david.node.pay_for_offer(&offer, None, None, None, payment_id, Retry::Attempts(0), None)
+		.unwrap();
+	expect_recent_payment!(david, RecentPaymentDetails::AwaitingInvoice, payment_id);
+
+	#[cfg(not(c_bindings))] {
+		david.node.pending_offers_messages.lock().unwrap().first_mut().unwrap().destination =
+			Destination::BlindedPath(invalid_path);
+	}
+	#[cfg(c_bindings)] {
+		david.node.pending_offers_messages.lock().unwrap().first_mut().unwrap().1 =
+			Destination::BlindedPath(invalid_path);
+	}
+
+	connect_peers(david, bob);
+
+	let onion_message = david.onion_messenger.next_onion_message_for_peer(bob_id).unwrap();
+	bob.onion_messenger.handle_onion_message(&david_id, &onion_message);
+
+	let onion_message = bob.onion_messenger.next_onion_message_for_peer(alice_id).unwrap();
+	alice.onion_messenger.handle_onion_message(&bob_id, &onion_message);
+
+	let (invoice_request, reply_path) = extract_invoice_request(alice, &onion_message);
+	assert_eq!(invoice_request.amount_msats(), None);
+	assert_ne!(invoice_request.payer_id(), david_id);
+	assert_eq!(reply_path.introduction_node, IntroductionNode::NodeId(charlie_id));
+
+	assert_eq!(alice.onion_messenger.next_onion_message_for_peer(charlie_id), None);
 }
 
 /// Check that authentication fails when an invoice is handled using the wrong context (i.e., was
@@ -1308,9 +1349,9 @@ fn fails_authentication_when_handling_invoice_for_refund() {
 	}
 	expect_recent_payment!(david, RecentPaymentDetails::AwaitingInvoice, payment_id);
 
+	// Send the invoice directly to David instead of using a blinded path.
 	let expected_invoice = alice.node.request_refund_payment(&refund).unwrap();
 
-	// Send the invoice directly to David instead of using a blinded path.
 	connect_peers(david, alice);
 	#[cfg(not(c_bindings))] {
 		alice.node.pending_offers_messages.lock().unwrap().first_mut().unwrap().destination =
@@ -1328,6 +1369,43 @@ fn fails_authentication_when_handling_invoice_for_refund() {
 	assert_eq!(invoice, expected_invoice);
 
 	expect_recent_payment!(david, RecentPaymentDetails::AwaitingInvoice, payment_id);
+
+	// Send the invoice to David using an invalid blinded path.
+	let invalid_path = refund.paths().first().unwrap().clone();
+	let payment_id = PaymentId([2; 32]);
+	let refund = david.node
+		.create_refund_builder(10_000_000, absolute_expiry, payment_id, Retry::Attempts(0), None)
+		.unwrap()
+		.build().unwrap();
+	assert_ne!(refund.payer_id(), david_id);
+	assert!(!refund.paths().is_empty());
+	for path in refund.paths() {
+		assert_eq!(path.introduction_node, IntroductionNode::NodeId(charlie_id));
+	}
+
+	let expected_invoice = alice.node.request_refund_payment(&refund).unwrap();
+
+	#[cfg(not(c_bindings))] {
+		alice.node.pending_offers_messages.lock().unwrap().first_mut().unwrap().destination =
+			Destination::BlindedPath(invalid_path);
+	}
+	#[cfg(c_bindings)] {
+		alice.node.pending_offers_messages.lock().unwrap().first_mut().unwrap().1 =
+			Destination::BlindedPath(invalid_path);
+	}
+
+	connect_peers(alice, charlie);
+
+	let onion_message = alice.onion_messenger.next_onion_message_for_peer(charlie_id).unwrap();
+	charlie.onion_messenger.handle_onion_message(&alice_id, &onion_message);
+
+	let onion_message = charlie.onion_messenger.next_onion_message_for_peer(david_id).unwrap();
+	david.onion_messenger.handle_onion_message(&charlie_id, &onion_message);
+
+	let invoice = extract_invoice(david, &onion_message);
+	assert_eq!(invoice, expected_invoice);
+
+	expect_recent_payment!(david, RecentPaymentDetails::AwaitingInvoice, payment_id);
 }
 
 /// Fails creating or paying an offer when a blinded path cannot be created because no peers are