f reorder param

Author: TheBlueMatt

lightning/src/routing/scoring.rs

@@ -1007,7 +1007,7 @@ const BASE_AMOUNT_PENALTY_DIVISOR: u64 = 1 << 30;
 /// (recently) seen an HTLC successfully complete over this channel.
 #[inline(always)]
 fn success_probability(
-	min_liquidity_msat: u64, amount_msat: u64, max_liquidity_msat: u64, _capacity_msat: u64,
+	amount_msat: u64, min_liquidity_msat: u64, max_liquidity_msat: u64, _capacity_msat: u64,
 	_params: &ProbabilisticScoringFeeParameters, _min_zero_implies_no_successes: bool,
 ) -> (u64, u64) {
 	let numerator = max_liquidity_msat - amount_msat;
@@ -1035,8 +1035,8 @@ impl<L: Deref<Target = u64>, BRT: Deref<Target = HistoricalBucketRangeTracker>,
 					score_params.liquidity_penalty_amount_multiplier_msat)
 				.saturating_add(score_params.considered_impossible_penalty_msat)
 		} else {
-			let (numerator, denominator) = success_probability(min_liquidity_msat,
-				amount_msat, max_liquidity_msat, available_capacity, score_params, false);
+			let (numerator, denominator) = success_probability(amount_msat,
+				min_liquidity_msat, max_liquidity_msat, available_capacity, score_params, false);
 			if denominator - numerator < denominator / PRECISION_LOWER_BOUND_DENOMINATOR {
 				// If the failure probability is < 1.5625% (as 1 - numerator/denominator < 1/64),
 				// don't bother trying to use the log approximation as it gets too noisy to be
@@ -1075,7 +1075,7 @@ impl<L: Deref<Target = u64>, BRT: Deref<Target = HistoricalBucketRangeTracker>,
 				// If we don't have any valid points (or, once decayed, we have less than a full
 				// point), redo the non-historical calculation with no liquidity bounds tracked and
 				// the historical penalty multipliers.
-				let (numerator, denominator) = success_probability(0, amount_msat,
+				let (numerator, denominator) = success_probability(amount_msat, 0,
 					available_capacity, available_capacity, score_params, true);
 				let negative_log10_times_2048 =
 					approx::negative_log10_times_2048(numerator, denominator);
@@ -1906,7 +1906,7 @@ mod bucketed_history {
 				}
 				let max_bucket_end_pos = BUCKET_START_POS[32 - highest_max_bucket_with_points] - 1;
 				if payment_pos < max_bucket_end_pos {
-					let (numerator, denominator) = success_probability(0, payment_pos as u64,
+					let (numerator, denominator) = success_probability(payment_pos as u64, 0,
 						max_bucket_end_pos as u64, POSITION_TICKS as u64 - 1, params, true);
 					let bucket_prob_times_billion =
 						(self.min_liquidity_offset_history.buckets[0] as u64) * total_max_points
@@ -1930,9 +1930,9 @@ mod bucketed_history {
 					} else if payment_pos < min_bucket_start_pos {
 						cumulative_success_prob_times_billion += bucket_prob_times_billion;
 					} else {
-						let (numerator, denominator) = success_probability(
-							min_bucket_start_pos as u64, payment_pos as u64,
-							max_bucket_end_pos as u64, POSITION_TICKS as u64 - 1, params, true);
+						let (numerator, denominator) = success_probability(payment_pos as u64,
+							min_bucket_start_pos as u64, max_bucket_end_pos as u64,
+							POSITION_TICKS as u64 - 1, params, true);
 						cumulative_success_prob_times_billion += bucket_prob_times_billion *
 							numerator / denominator;
 					}