Skip to content

Commit cd42592

Browse files
committed
Drop redundant rustup overrides when we just installed
There's no reason to set the default toolchain when we just installed the toolchain. Also, for some reason this now fails since the `$PATH` isn't updated by the installer in the same shell so `rustup` isn't found.
1 parent a6d1812 commit cd42592

File tree

1 file changed

+0
-9
lines changed

1 file changed

+0
-9
lines changed

.github/workflows/build.yml

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,6 @@ jobs:
2121
- name: Install Rust stable toolchain
2222
run: |
2323
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain stable
24-
rustup override set stable
2524
- name: Run externalized tests
2625
run: |
2726
cd ext-functional-test-demo
@@ -43,7 +42,6 @@ jobs:
4342
- name: Install Rust ${{ matrix.toolchain }} toolchain
4443
run: |
4544
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ matrix.toolchain }}
46-
rustup override set ${{ matrix.toolchain }}
4745
- name: Install no-std-check dependencies for ARM Embedded
4846
if: "matrix.platform == 'self-hosted'"
4947
run: |
@@ -77,7 +75,6 @@ jobs:
7775
- name: Install Rust ${{ matrix.toolchain }} toolchain
7876
run: |
7977
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ matrix.toolchain }}
80-
rustup override set ${{ matrix.toolchain }}
8178
- name: Set RUSTFLAGS to deny warnings
8279
if: "matrix.toolchain == '1.75.0'"
8380
run: echo "RUSTFLAGS=-D warnings" >> "$GITHUB_ENV"
@@ -150,7 +147,6 @@ jobs:
150147
- name: Install Rust ${{ env.TOOLCHAIN }} toolchain
151148
run: |
152149
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
153-
rustup override set ${{ env.TOOLCHAIN }}
154150
- name: Cache routing graph snapshot
155151
id: cache-graph
156152
uses: actions/cache@v4
@@ -217,7 +213,6 @@ jobs:
217213
- name: Install Rust ${{ env.TOOLCHAIN }} toolchain
218214
run: |
219215
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
220-
rustup override set ${{ env.TOOLCHAIN }}
221216
- name: Fetch full tree and rebase on upstream
222217
run: |
223218
git remote add upstream https://github.com/lightningdevkit/rust-lightning
@@ -240,7 +235,6 @@ jobs:
240235
- name: Install Rust ${{ env.TOOLCHAIN }} toolchain
241236
run: |
242237
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
243-
rustup override set ${{ env.TOOLCHAIN }}
244238
- name: Run cargo check for release build.
245239
run: |
246240
cargo check --release
@@ -267,7 +261,6 @@ jobs:
267261
- name: Install Rust ${{ env.TOOLCHAIN }} toolchain
268262
run: |
269263
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
270-
rustup override set ${{ env.TOOLCHAIN }}
271264
- name: Install dependencies for honggfuzz
272265
run: |
273266
sudo apt-get update
@@ -295,7 +288,6 @@ jobs:
295288
- name: Install Rust ${{ env.TOOLCHAIN }} toolchain
296289
run: |
297290
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
298-
rustup override set ${{ env.TOOLCHAIN }}
299291
- name: Install clippy
300292
run: |
301293
rustup component add clippy
@@ -313,7 +305,6 @@ jobs:
313305
- name: Install Rust ${{ env.TOOLCHAIN }} toolchain
314306
run: |
315307
curl --proto '=https' --tlsv1.2 -sSf https://sh.rustup.rs | sh -s -- -y --profile=minimal --default-toolchain ${{ env.TOOLCHAIN }}
316-
rustup override set ${{ env.TOOLCHAIN }}
317308
- name: Install rustfmt
318309
run: |
319310
rustup component add rustfmt

0 commit comments

Comments
 (0)