Expose onion_error_code in DecodedOnionFailure in cfg(not(test)).

Will be used to detect when we should cache a blinded payment path as having
previously failed to avoid retrying over it.

Author: valentinewallace

lightning/src/ln/onion_utils.rs

@@ -429,7 +429,6 @@ pub(crate) struct DecodedOnionFailure {
 	pub(crate) network_update: Option<NetworkUpdate>,
 	pub(crate) short_channel_id: Option<u64>,
 	pub(crate) payment_failed_permanently: bool,
-	#[cfg(test)]
 	pub(crate) onion_error_code: Option<u16>,
 	#[cfg(test)]
 	pub(crate) onion_error_data: Option<Vec<u8>>,
@@ -721,7 +720,6 @@ pub(super) fn process_onion_failure<T: secp256k1::Signing, L: Deref>(
 	}) = res {
 		DecodedOnionFailure {
 			network_update, short_channel_id, payment_failed_permanently,
-			#[cfg(test)]
 			onion_error_code: error_code_ret,
 			#[cfg(test)]
 			onion_error_data: error_packet_ret
@@ -731,7 +729,6 @@ pub(super) fn process_onion_failure<T: secp256k1::Signing, L: Deref>(
 		// payment not retryable only when garbage is from the final node
 		DecodedOnionFailure {
 			network_update: None, short_channel_id: None, payment_failed_permanently: is_from_final_node,
-			#[cfg(test)]
 			onion_error_code: None,
 			#[cfg(test)]
 			onion_error_data: None
@@ -878,7 +875,6 @@ impl HTLCFailReason {
 						network_update: None,
 						payment_failed_permanently: false,
 						short_channel_id: Some(path.hops[0].short_channel_id),
-						#[cfg(test)]
 						onion_error_code: Some(*failure_code),
 						#[cfg(test)]
 						onion_error_data: Some(data.clone()),

lightning/src/ln/outbound_payment.rs

@@ -1607,8 +1607,9 @@ impl OutboundPayments {
 			onion_error_data
 		} = onion_error.decode_onion_failure(secp_ctx, logger, &source);
 		#[cfg(not(test))]
-		let DecodedOnionFailure { network_update, short_channel_id, payment_failed_permanently } =
-			onion_error.decode_onion_failure(secp_ctx, logger, &source);
+		let DecodedOnionFailure {
+			network_update, short_channel_id, payment_failed_permanently, onion_error_code,
+		} = onion_error.decode_onion_failure(secp_ctx, logger, &source);
 
 		let payment_is_probe = payment_is_probe(payment_hash, &payment_id, probing_cookie_secret);
 		let mut session_priv_bytes = [0; 32];