Add new PaymentFailureReason::BlindedPathCreationFailed

RouteNotFound did not fit here because that error is reserved for failing to
find a route for a payment, whereas here we are failing to create a blinded
path back to ourselves..

Author: valentinewallace

lightning/src/events/mod.rs

@@ -577,6 +577,12 @@ pub enum PaymentFailureReason {
 	///
 	/// [`InvoiceRequest`]: crate::offers::invoice_request::InvoiceRequest
 	InvoiceRequestRejected,
+	/// Failed to create a blinded path back to ourselves.
+	/// We attempted to initiate payment to a static invoice but failed to create a reply path for our
+	/// [`HeldHtlcAvailable`] message.
+	///
+	/// [`HeldHtlcAvailable`]: crate::onion_message::async_payments::HeldHtlcAvailable
+	BlindedPathCreationFailed,
 }
 
 impl_writeable_tlv_based_enum_upgradable!(PaymentFailureReason,
@@ -589,6 +595,7 @@ impl_writeable_tlv_based_enum_upgradable!(PaymentFailureReason,
 	(6, PaymentExpired) => {},
 	(8, RouteNotFound) => {},
 	(10, UnexpectedError) => {},
+	(12, BlindedPathCreationFailed) => {},
 );
 
 /// An Event which you should probably take some action in response to.
@@ -1651,6 +1658,8 @@ impl Writeable for Event {
 						&Some(PaymentFailureReason::RetriesExhausted),
 					Some(PaymentFailureReason::InvoiceRequestRejected) =>
 						&Some(PaymentFailureReason::RecipientRejected),
+					Some(PaymentFailureReason::BlindedPathCreationFailed) =>
+						&Some(PaymentFailureReason::RouteNotFound)
 				};
 				write_tlv_fields!(writer, {
 					(0, payment_id, required),

lightning/src/ln/channelmanager.rs

@@ -4463,7 +4463,7 @@ where
 			) {
 				Ok(paths) => paths,
 				Err(()) => {
-					self.abandon_payment_with_reason(payment_id, PaymentFailureReason::RouteNotFound);
+					self.abandon_payment_with_reason(payment_id, PaymentFailureReason::BlindedPathCreationFailed);
 					res = Err(Bolt12PaymentError::BlindedPathCreationFailed);
 					return NotifyOption::DoPersist
 				}