f rm side-effects from and_then

Author: dunxen

lightning/src/ln/channelmanager.rs

@@ -4960,53 +4960,6 @@ where
 		result
 	}
 
-	/// Handles a signed funding transaction generated by interactive transaction construction and
-	/// provided by the client.
-	///
-	/// Do NOT broadcast the funding transaction yourself. When we have safely received our
-	/// counterparty's signature(s) the funding transaction will automatically be broadcast via the
-	/// [`BroadcasterInterface`] provided when this `ChannelManager` was constructed.
-	pub fn funding_transaction_signed(
-		&self, channel_id: &ChannelId, counterparty_node_id: &PublicKey, transaction: Transaction
-	) -> Result<(), APIError> {
-		let witnesses: Vec<_> = transaction.input.into_iter().filter_map(|input| {
-			if input.witness.is_empty() { None } else { Some(input.witness) }
-		}).collect();
-
-		let per_peer_state = self.per_peer_state.read().unwrap();
-		let peer_state_mutex = per_peer_state.get(counterparty_node_id)
-			.ok_or_else(|| APIError::ChannelUnavailable {
-				err: format!("Can't find a peer matching the passed counterparty node_id {}",
-					counterparty_node_id) })?;
-
-		let mut peer_state_lock = peer_state_mutex.lock().unwrap();
-		let peer_state = &mut *peer_state_lock;
-
-		match peer_state.channel_by_id.get_mut(channel_id) {
-			Some(ChannelPhase::Funded(chan)) => {
-				chan.verify_interactive_tx_signatures(&witnesses);
-				if let Some(ref mut signing_session) = chan.interactive_tx_signing_session {
-					if let Some(tx_signatures) = signing_session.provide_holder_witnesses(*channel_id, witnesses) {
-						peer_state.pending_msg_events.push(events::MessageSendEvent::SendTxSignatures {
-							node_id: *counterparty_node_id,
-							msg: tx_signatures,
-						});
-					}
-				} else {
-					return Err(APIError::APIMisuseError {
-						err: format!("Channel with id {} not expecting funding signatures", channel_id)});
-				}
-			},
-			Some(_) => return Err(APIError::APIMisuseError {
-				err: format!("Channel with id {} not expecting funding signatures", channel_id)}),
-			None => return Err(APIError::ChannelUnavailable{
-				err: format!("Channel with id {} not found for the passed counterparty node_id {}", channel_id,
-					counterparty_node_id) }),
-		}
-
-		Ok(())
-	}
-
 	/// Atomically applies partial updates to the [`ChannelConfig`] of the given channels.
 	///
 	/// Once the updates are applied, each eligible channel (advertised with a known short channel
@@ -8110,7 +8063,7 @@ where
 					peer_state.pending_msg_events.push(msg_send_event);
 				};
 				if let Some(mut signing_session) = signing_session_opt {
-					match chan_phase_entry.get_mut() {
+					let (commitment_signed, funding_ready_for_sig_event_opt) = match chan_phase_entry.get_mut() {
 						ChannelPhase::UnfundedOutboundV2(chan) => {
 							chan.funding_tx_constructed(&mut signing_session, &self.logger)
 						},
@@ -8120,23 +8073,18 @@ where
 						_ => Err(ChannelError::Warn(
 							"Got a tx_complete message with no interactive transaction construction expected or in-progress"
 							.into())),
-					}.and_then(|(commitment_signed, funding_ready_for_sig_event_opt)| {
-							let (channel_id, channel_phase) = chan_phase_entry.remove_entry();
-							match channel_phase {
-								ChannelPhase::UnfundedOutboundV2(chan) => {
-									chan.into_channel(signing_session)
-								},
-								ChannelPhase::UnfundedInboundV2(chan) => {
-									chan.into_channel(signing_session)
-								},
+					}.map_err(|err| MsgHandleErrInternal::send_err_msg_no_close(format!("{}", err), msg.channel_id))?;
+					let (channel_id, channel_phase) = chan_phase_entry.remove_entry();
+							let channel = match channel_phase {
+								ChannelPhase::UnfundedOutboundV2(chan) => chan.into_channel(signing_session),
+								ChannelPhase::UnfundedInboundV2(chan) => chan.into_channel(signing_session),
 								_ => {
 									debug_assert!(false); // It cannot be another variant as we are in the `Ok` branch of the above match.
 									Err(ChannelError::Warn(
 										"Got a tx_complete message with no interactive transaction construction expected or in-progress"
 											.into()))
-								}
-							}.map(|channel| (channel_id, channel, funding_ready_for_sig_event_opt, commitment_signed))
-						}).map(|(channel_id, channel, funding_ready_for_sig_event_opt, commitment_signed)| {
+								},
+							}.map_err(|err| MsgHandleErrInternal::send_err_msg_no_close(format!("{}", err), msg.channel_id))?;
 							peer_state.channel_by_id.insert(channel_id, ChannelPhase::Funded(channel));
 							if let Some(funding_ready_for_sig_event) = funding_ready_for_sig_event_opt {
 								let mut pending_events = self.pending_events.lock().unwrap();
@@ -8153,11 +8101,8 @@ where
 									update_fee: None,
 								},
 							});
-						}).map_err(|err| MsgHandleErrInternal::send_err_msg_no_close(format!("{}", err), msg.channel_id))
-				} else {
-					// We're not in a signing session yet so we don't need to do anything else.
-					Ok(())
-				}
+						}
+						Ok(())
 			},
 			hash_map::Entry::Vacant(_) => {
 				Err(MsgHandleErrInternal::send_err_msg_no_close(format!("Got a message for a channel from the wrong node! No such channel for the passed counterparty_node_id {}", counterparty_node_id), msg.channel_id))