Skip to content

Commit f1e4645

Browse files
Fix final blinded hop CLTV expiry on send.
Previously, we were setting the final blinded hop's CLTV expiry height to best_block_height + total_blinded_path_cltv_delta + shadow_cltv_offset. This is incorrect, it should instead be set to best_block_height + shadow_cltv_offset only -- it doesn't make sense to include the delta for the other blinded hops in the final hop's expiry. The reason this too-high final cltv value didn't cause test failures previously is because of a 2nd bug that is fixed in an upcoming commit where the sender adds the shadow offset twice to the total path CLTV expiry. This 2nd offset meant that intermediate nodes had some buffer CLTV to subtract their delta from while still (usually) have enough leftover to meet the expiry in the final hop's onion.
1 parent 4a0170a commit f1e4645

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lightning/src/ln/onion_utils.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ pub(super) fn build_onion_payloads(path: &Path, total_msat: u64, mut recipient_o
192192
res.push(msgs::OutboundOnionPayload::BlindedReceive {
193193
sender_intended_htlc_amt_msat: *final_value_msat,
194194
total_msat,
195-
cltv_expiry_height: cltv,
195+
cltv_expiry_height: cur_cltv,
196196
encrypted_tlvs: blinded_hop.encrypted_payload.clone(),
197197
intro_node_blinding_point: blinding_point.take(),
198198
});

0 commit comments

Comments
 (0)