Skip to content

Conversation

@arik-so
Copy link
Contributor

@arik-so arik-so commented Oct 4, 2024

No description provided.

@arik-so arik-so marked this pull request as ready for review October 4, 2024 08:26
@codecov
Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.59%. Comparing base (bc1931b) to head (931ddcb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3350      +/-   ##
==========================================
- Coverage   89.62%   89.59%   -0.03%     
==========================================
  Files         127      127              
  Lines      103517   103517              
  Branches   103517   103517              
==========================================
- Hits        92775    92747      -28     
- Misses       8046     8069      +23     
- Partials     2696     2701       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@arik-so
Copy link
Contributor Author

arik-so commented Oct 4, 2024

On second thought, shouldn't actually be necessary given it's merely a patch bump and Cargo should automatically be grabbing the latest one.

@arik-so arik-so closed this Oct 4, 2024
Copy link
Contributor

@tnull tnull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bumping to 0.32.3 should happen automatically, or users might choose to force it via cargo update, no?

Usually, the version in the Cargo.toml should reflect the minimum supported version to allow for some degrees of freedom on the user's end. I.e., if we don't require a specific API introduced with 0.32.3, we likely shouldn't bump it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants