Skip to content

Cut 0.0.125 with a few bugfixes #3362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Oct 14, 2024
Merged

Cut 0.0.125 with a few bugfixes #3362

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
68d27bc
Set `holder_commitment_point` to `Available` on upgrade
TheBlueMatt Oct 14, 2024
acfc6d9
Don't bump the `next_node_counter` when using a removed counter
TheBlueMatt Oct 14, 2024
a675d48
Fix `synchronize_listeners` calling default implementation
tnull Oct 10, 2024
e48074a
Don't interpret decayed data as we've failed to send tiny values
TheBlueMatt Oct 14, 2024
a6834eb
Fix `docs.rs` for crates which depend on `lightning` w/o features
TheBlueMatt Oct 14, 2024
f0f1b22
Bump crate versions to 0.0.125
TheBlueMatt Oct 14, 2024
2028c78
Add CHANGELOG entry for 0.0.125
TheBlueMatt Oct 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions lightning-background-processor/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ edition = "2021"

[package.metadata.docs.rs]
all-features = true
features = ["lightning/std"]
Copy link
Contributor

@tnull tnull Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhh, does this actually work or do we also need to set it on RGS and the BP? Do we know of any way to validate this without running docs.rs in a container etc?

Copy link
Collaborator Author

@TheBlueMatt TheBlueMatt Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uploaded the BP depending on 124 as https://docs.rs/crate/docs-rs-test-bluematt-delete-this/latest

Copy link
Contributor

@tnull tnull Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems broken?

Copy link
Collaborator Author

@TheBlueMatt TheBlueMatt Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, looks like it works.

Copy link
Contributor

@tnull tnull Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"The requested version does not exist"?

Copy link
Collaborator Author

@TheBlueMatt TheBlueMatt Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I guess when I yanked the crate it deleted it...it did work, though.

Copy link
Contributor

@tnull tnull Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhh, previously I got another page that however still looked broken (links not working etc). Any case, fingers crossed it will look unbroken on docs.rs.

rustdoc-args = ["--cfg", "docsrs"]

[features]
Expand Down
4 changes: 4 additions & 0 deletions lightning-rapid-gossip-sync/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,10 @@ description = """
Utility to process gossip routing data from Rapid Gossip Sync Server.
"""

[package.metadata.docs.rs]
all-features = true
features = ["lightning/std"]

[features]
default = ["std"]
std = []
Expand Down