Follow-up to #3481: Assert we migrated all exactly all keys #3491
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we'd only check that the number of migrated keys and that the migrated data is correct. Here, we also check that all the Previously-written keys are migrated as expected.
tnull
force-pushed
the
2024-12-3481-followup
branch
from
33d3a44 to
f85e96d
Compare
Collaborator
|
Oops, sorry. This wasn't all that critical, but I went ahead and shoved it in #3490 (which wasn't intended as a fuzzing PR at all until I started testing...) |
Contributor
Author
Okay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #3481
Previously, we'd only check that the number of migrated keys and that the migrated data is correct. Here, we also check that all the Previously-written keys are migrated as expected.