Expose inner field of LSPSDateTime constructor
#3781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We require users to construct an `LSPSDateTime` and give it back to us (e.g., in LSPS2 OpeningFeeParameters), but currently only offer construction via `FromStr`. Here, we simply expose the wrapped `DateTime` field, allowing users to construct an `LSPSDateTime`.
|
👋 Thanks for assigning @TheBlueMatt as a reviewer! |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We require users to construct an
LSPSDateTimeand give it back to us (e.g., in LSPS2 OpeningFeeParameters), but currently only offer construction viaFromStr. Here, we simply expose the wrappedDateTimefield, allowing users to construct anLSPSDateTime.