Support splicing in ChannelContext::funding_tx_constructed
#3982
Conversation
|
👋 Thanks for assigning @wpaulino as a reviewer! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3982 +/- ##
==========================================
+ Coverage 88.94% 88.98% +0.04%
==========================================
Files 174 174
Lines 124201 124223 +22
Branches 124201 124223 +22
==========================================
+ Hits 110472 110544 +72
+ Misses 11251 11204 -47
+ Partials 2478 2475 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
🔔 1st Reminder Hey @wpaulino! This PR has been waiting for your review. |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
jkczyz
force-pushed
the
2025-08-get-initial-commitment-signed
branch
from
e309a6b to
f3eb10b
Compare
|
CI is failing |
The ChannelState::NegotiatingFunding assertion check in ChannelContext::get_initial_commitment_signed will fail when implementing splicing's channel_reestablish logic. In order to support it and channel establishment, enter ChannelState::FundingNegotiated prior to calling the method and update the assertion accordingly. Also allows writing a channel in the FundedNegotiated state when an interactive signing session is active. This is necessary as it indicates a previously funded channel being spliced.
When ChannelContext::get_initial_commitment_signed is called for V2 channel establishment, any errors should result in closing the channel. However, in the future, when this is used for splicing it should abort instead of closing the channel. Move the error construction to the call sites in anticipation of this.
jkczyz
force-pushed
the
2025-08-get-initial-commitment-signed
branch
from
f3eb10b to
63604cb
Compare
The
ChannelState::NegotiatingFundingassertion check inChannelContext::get_initial_commitment_signedwill fail when implementing splicing'schannel_reestablishlogic. In order to support it and channel establishment, enterChannelState::FundingNegotiatedprior to calling the method and update the assertion accordingly.Additionally, update relevant signing methods to use an
Optioninstead of aResultwith aChannelErrorsince failures result in aTxAbortanyhow.Commits from this PR were extracted from #3886 to facilitate splicing testing.