Add a method to avoid re-persisting monitors during startup #3996
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
Prior to LDK 0.1, in rare cases we could replay payment claims to `ChannelMonitor`s on startup, which we then expected to be persisted prior to normal node operation. This required re-persisting `ChannelMonitor`s after deserializing the `ChannelManager`, delaying startup in some cases substantially. In 0.1 we fixed this, moving claim replays to the background to run after the `ChannelManager` starts operating (and only updating/persisting changes to the `ChannelMonitor`s which need it). However, we didn't actually enable this meaningfully in our API - nearly all users use our `ChainMonitor` and the only way to get a chanel into `ChainMonitor` is through the normal flow which expects to persist. Here we add a simple method to load `ChannelMonitor`s into the `ChainMonitor` without persisting them.
TheBlueMatt
force-pushed
the
2025-08-faster-0.1-load
branch
from
f968fa1 to
e45bfed
Compare
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
Yeah, I'd also lean towards not backporting this, also as it changes API (even though just extending). |
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3996 +/- ##
=======================================
Coverage 88.93% 88.94%
=======================================
Files 174 174
Lines 124575 124629 +54
Branches 124575 124629 +54
=======================================
+ Hits 110790 110850 +60
+ Misses 11287 11280 -7
- Partials 2498 2499 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prior to LDK 0.1, in rare cases we could replay payment claims to
ChannelMonitors on startup, which we then expected to be persisted prior to normal node operation. This required re-persistingChannelMonitors after deserializing theChannelManager, delaying startup in some cases substantially.In 0.1 we fixed this, moving claim replays to the background to run after the
ChannelManagerstarts operating (and only updating/persisting changes to theChannelMonitors which need it). However, we didn't actually enable this meaningfully in our API - nearly all users use ourChainMonitorand the only way to get a chanel intoChainMonitoris through the normal flow which expects to persist.Here we add a simple method to load
ChannelMonitors into theChainMonitorwithout persisting them.I'm kinda on the fence about backporting this. On the one hand its a pretty nontrivial speedup for users who switch to the new interface. On the other hand, it is a "feature" and its kinda weird to backport a feature.