LSPS2ServiceHandler API: Avoid explictly dropping locks
#4124
+88
−93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We previously added some explict `drop`s to make sure to drop locks before persisting. While clippy warned us about them, they seemed perfectly functional. However, it weirdly seems that `cargo` will run the same static analysis on dependencies, which has LDK Node builds fail with many dreaded 'isn't `Send`' error whenever we touch the async `LSPS2ServiceHandler` API. Here, we simply believe clippy that this is a bad idea and use scoping over explict `drop`s to ensure we don't hold them anymore when persisting.
|
👋 Thanks for assigning @joostjager as a reviewer! |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4124 +/- ##
==========================================
- Coverage 88.54% 88.53% -0.01%
==========================================
Files 179 179
Lines 134333 134329 -4
Branches 134333 134329 -4
==========================================
- Hits 118939 118928 -11
- Misses 12634 12646 +12
+ Partials 2760 2755 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
joostjager
approved these changes
Sep 25, 2025
|
👋 The first review has been submitted! Do you think this PR is ready for a second reviewer? If so, click here to assign a second reviewer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #4059.
We previously added some explict
drops to make sure to drop locks before persisting. While clippy warned us about them, they seemed perfectly functional. However, it weirdly seems thatcargowill run the same static analysis on dependencies, which has LDK Node builds fail with many dreaded 'isn'tSend' error whenever we touch the asyncLSPS2ServiceHandlerAPI.Here, we simply believe clippy that this is a bad idea and use scoping over explict
drops to ensure we don't hold them anymore when persisting.Best reviewed with
git diff --ignore-all-space, which makes the diff trivial.