fixup! Add VssService and base service setup.

Author: G8XSU

rust/server/src/main.rs

@@ -1,3 +1,14 @@
+//! Hosts VSS http-server implementation.
+//!
+//! VSS is an open-source project designed to offer a server-side cloud storage solution specifically
+//! tailored for noncustodial Lightning supporting mobile wallets. Its primary objective is to
+//! simplify the development process for Lightning wallets by providing a secure means to store
+//! and manage the essential state required for Lightning Network (LN) operations.
+
+#![deny(rustdoc::broken_intra_doc_links)]
+#![deny(rustdoc::private_intra_doc_links)]
+#![deny(missing_docs)]
+
 use std::net::SocketAddr;
 
 use tokio::net::TcpListener;

rust/server/src/vss_service.rs

@@ -1,7 +1,7 @@
 use http_body_util::{BodyExt, Full};
 use hyper::body::{Bytes, Incoming};
 use hyper::service::Service;
-use hyper::{Error, Request, Response, StatusCode};
+use hyper::{Request, Response, StatusCode};
 use std::collections::HashMap;
 
 use prost::Message;
@@ -94,7 +94,6 @@ async fn handle_request<
 	store: Arc<dyn KvStore>, authorizer: Arc<dyn Authorizer>, request: Request<Incoming>,
 	handler: F,
 ) -> Result<<VssService as Service<Request<Incoming>>>::Response, hyper::Error> {
-	// TODO: we should bound the amount of data we read to avoid allocating too much memory.
 	let (parts, body) = request.into_parts();
 	let headers_map = parts
 		.headers
@@ -104,17 +103,17 @@ async fn handle_request<
 
 	let user_token = match authorizer.verify(&headers_map).await {
 		Ok(auth_response) => auth_response.user_token,
-		Err(e) => return build_error_response(e),
+		Err(e) => return Ok(build_error_response(e)),
 	};
-
+	// TODO: we should bound the amount of data we read to avoid allocating too much memory.
 	let bytes = body.collect().await?.to_bytes();
 	match T::decode(bytes) {
 		Ok(request) => match handler(store.clone(), user_token, request).await {
 			Ok(response) => Ok(Response::builder()
 				.body(Full::new(Bytes::from(response.encode_to_vec())))
 				// unwrap safety: body only errors when previous chained calls failed.
 				.unwrap()),
-			Err(e) => build_error_response(e),
+			Err(e) => Ok(build_error_response(e)),
 		},
 		Err(_) => Ok(Response::builder()
 			.status(StatusCode::BAD_REQUEST)
@@ -124,7 +123,7 @@ async fn handle_request<
 	}
 }
 
-fn build_error_response(e: VssError) -> Result<Response<Full<Bytes>>, Error> {
+fn build_error_response(e: VssError) -> Response<Full<Bytes>> {
 	let error_response = match e {
 		VssError::NoSuchKeyError(msg) => ErrorResponse {
 			error_code: ErrorCode::NoSuchKeyException.into(),
@@ -146,9 +145,9 @@ fn build_error_response(e: VssError) -> Result<Response<Full<Bytes>>, Error> {
 			message: "Unknown Server Error occurred.".to_string(),
 		},
 	};
-	Ok(Response::builder()
+	Response::builder()
 		.status(StatusCode::INTERNAL_SERVER_ERROR)
 		.body(Full::new(Bytes::from(error_response.encode_to_vec())))
 		// unwrap safety: body only errors when previous chained calls failed.
-		.unwrap())
+		.unwrap()
 }