multi: compile-time dependency of lnd to 0.19.0

Important notes.
 - channeldb was split to channeldb and graphdb
 - chanbackup.NewMultiFile got additional argument noBackupArchive, I pass false
 - Go updated to 1.23.6
 - golangci-lint updated to v1.64.5

Author: starius

.github/workflows/main.yml

@@ -16,7 +16,7 @@ env:
   # go needs absolute directories, using the $HOME variable doesn't work here.
   GOCACHE: /home/runner/work/go/pkg/build
   GOPATH: /home/runner/work/go
-  GO_VERSION: 1.22.6
+  GO_VERSION: 1.23.6
 
 jobs:
   ########################

README.md

@@ -39,7 +39,7 @@ $ sudo mv chantools-*/chantools /usr/local/bin/
 
 If there isn't a pre-built binary for your operating system or architecture
 available or you want to build `chantools` from source for another reason, you
-need to make sure you have `go 1.22.3` (or later) and `make` installed and can
+need to make sure you have `go 1.23.6` (or later) and `make` installed and can
 then run the following commands:
 
 ```bash

btc/summary.go

@@ -3,7 +3,7 @@ package btc
 import (
 	"errors"
 
-	"github.com/btcsuite/btclog"
+	"github.com/btcsuite/btclog/v2"
 	"github.com/lightninglabs/chantools/dataformat"
 )
 

cmd/chantools/chanbackup.go

@@ -58,11 +58,11 @@ func (c *chanBackupCommand) Execute(_ *cobra.Command, _ []string) error {
 	if c.ChannelDB == "" {
 		return errors.New("channel DB is required")
 	}
-	db, err := lnd.OpenDB(c.ChannelDB, true)
+	db, _, err := lnd.OpenDB(c.ChannelDB, true)
 	if err != nil {
 		return fmt.Errorf("error opening rescue DB: %w", err)
 	}
-	multiFile := chanbackup.NewMultiFile(c.MultiFile)
+	multiFile := chanbackup.NewMultiFile(c.MultiFile, noBackupArchive)
 	keyRing := &lnd.HDKeyRing{
 		ExtendedKey: extendedKey,
 		ChainParams: chainParams,

cmd/chantools/deletepayments.go

@@ -48,11 +48,13 @@ func (c *deletePaymentsCommand) Execute(_ *cobra.Command, _ []string) error {
 	if c.ChannelDB == "" {
 		return errors.New("channel DB is required")
 	}
-	db, err := lnd.OpenDB(c.ChannelDB, false)
+	db, _, err := lnd.OpenDB(c.ChannelDB, false)
 	if err != nil {
 		return fmt.Errorf("error opening rescue DB: %w", err)
 	}
 	defer func() { _ = db.Close() }()
 
-	return db.DeletePayments(c.FailedOnly, false)
+	_, err = db.DeletePayments(c.FailedOnly, false)
+
+	return err
 }

cmd/chantools/dropchannelgraph.go

@@ -13,18 +13,13 @@ import (
 	"github.com/lightninglabs/chantools/lnd"
 	"github.com/lightningnetwork/lnd/chainreg"
 	"github.com/lightningnetwork/lnd/channeldb"
-	"github.com/lightningnetwork/lnd/channeldb/models"
+	graphdb "github.com/lightningnetwork/lnd/graph/db"
+	"github.com/lightningnetwork/lnd/graph/db/models"
 	"github.com/lightningnetwork/lnd/keychain"
 	"github.com/lightningnetwork/lnd/lnwire"
 	"github.com/spf13/cobra"
 )
 
-var (
-	nodeBucket      = []byte("graph-node")
-	edgeBucket      = []byte("graph-edge")
-	graphMetaBucket = []byte("graph-meta")
-)
-
 type dropChannelGraphCommand struct {
 	ChannelDB       string
 	NodeIdentityKey string
@@ -85,11 +80,11 @@ func (c *dropChannelGraphCommand) Execute(_ *cobra.Command, _ []string) error {
 	if c.ChannelDB == "" {
 		return errors.New("channel DB is required")
 	}
-	db, err := lnd.OpenDB(c.ChannelDB, false)
+	channelDB, graphDB, err := lnd.OpenDB(c.ChannelDB, false)
 	if err != nil {
-		return fmt.Errorf("error opening rescue DB: %w", err)
+		return fmt.Errorf("error opening channel DB: %w", err)
 	}
-	defer func() { _ = db.Close() }()
+	defer func() { _ = channelDB.Close() }()
 
 	if c.NodeIdentityKey == "" {
 		return errors.New("node identity key is required")
@@ -107,7 +102,7 @@ func (c *dropChannelGraphCommand) Execute(_ *cobra.Command, _ []string) error {
 
 	if c.SingleChannel != 0 {
 		log.Infof("Removing single channel %d", c.SingleChannel)
-		return db.ChannelGraph().DeleteChannelEdges(
+		return graphDB.DeleteChannelEdges(
 			true, false, c.SingleChannel,
 		)
 	}
@@ -116,35 +111,20 @@ func (c *dropChannelGraphCommand) Execute(_ *cobra.Command, _ []string) error {
 	if !c.FixOnly {
 		log.Infof("Dropping all graph related buckets")
 
-		rwTx, err := db.BeginReadWriteTx()
-		if err != nil {
-			return err
-		}
-		if err := rwTx.DeleteTopLevelBucket(nodeBucket); err != nil {
-			return err
-		}
-		if err := rwTx.DeleteTopLevelBucket(edgeBucket); err != nil {
-			return err
-		}
-		if err := rwTx.DeleteTopLevelBucket(graphMetaBucket); err != nil {
-			return err
-		}
-
-		if err := rwTx.Commit(); err != nil {
-			return err
-		}
+		return graphDB.Wipe()
 	}
 
-	return insertOwnNodeAndChannels(idKey, db)
+	return insertOwnNodeAndChannels(idKey, channelDB, graphDB)
 }
 
-func insertOwnNodeAndChannels(idKey *btcec.PublicKey, db *channeldb.DB) error {
-	openChannels, err := db.ChannelStateDB().FetchAllOpenChannels()
+func insertOwnNodeAndChannels(idKey *btcec.PublicKey, channelDB *channeldb.DB,
+	graphDB *graphdb.ChannelGraph) error {
+
+	openChannels, err := channelDB.ChannelStateDB().FetchAllOpenChannels()
 	if err != nil {
 		return fmt.Errorf("error fetching open channels: %w", err)
 	}
 
-	graph := db.ChannelGraph()
 	for _, openChan := range openChannels {
 		edge, update, err := newChanAnnouncement(
 			idKey, openChan.IdentityPub,
@@ -159,11 +139,11 @@ func insertOwnNodeAndChannels(idKey *btcec.PublicKey, db *channeldb.DB) error {
 				err)
 		}
 
-		if err := graph.AddChannelEdge(edge); err != nil {
+		if err := graphDB.AddChannelEdge(edge); err != nil {
 			log.Warnf("Not adding channel edge %v because of "+
 				"error: %v", edge.ChannelPoint, err)
 		}
-		if err := graph.UpdateEdgePolicy(update); err != nil {
+		if err := graphDB.UpdateEdgePolicy(update); err != nil {
 			log.Warnf("Not updating edge policy %v because of "+
 				"error: %v", update.ChannelID, err)
 		}
@@ -184,7 +164,7 @@ func newChanAnnouncement(localPubKey, remotePubKey *btcec.PublicKey,
 	// The unconditional section of the announcement is the ShortChannelID
 	// itself which compactly encodes the location of the funding output
 	// within the blockchain.
-	chanAnn := &lnwire.ChannelAnnouncement{
+	chanAnn := &lnwire.ChannelAnnouncement1{
 		ShortChannelID: shortChanID,
 		Features:       lnwire.NewRawFeatureVector(),
 		ChainHash:      chainHash,
@@ -248,7 +228,7 @@ func newChanAnnouncement(localPubKey, remotePubKey *btcec.PublicKey,
 
 	// We announce the channel with the default values. Some of
 	// these values can later be changed by crafting a new ChannelUpdate.
-	chanUpdateAnn := &lnwire.ChannelUpdate{
+	chanUpdateAnn := &lnwire.ChannelUpdate1{
 		ShortChannelID: shortChanID,
 		ChainHash:      chainHash,
 		Timestamp:      uint32(time.Now().Unix()),

cmd/chantools/dropgraphzombies.go

@@ -5,11 +5,12 @@ import (
 	"fmt"
 
 	"github.com/lightninglabs/chantools/lnd"
-	"github.com/lightningnetwork/lnd/channeldb"
+	graphdb "github.com/lightningnetwork/lnd/graph/db"
 	"github.com/spf13/cobra"
 )
 
 var (
+	edgeBucket   = []byte("graph-edge")
 	zombieBucket = []byte("zombie-index")
 )
 
@@ -55,7 +56,7 @@ func (c *dropGraphZombiesCommand) Execute(_ *cobra.Command, _ []string) error {
 	if c.ChannelDB == "" {
 		return errors.New("channel DB is required")
 	}
-	db, err := lnd.OpenDB(c.ChannelDB, false)
+	db, _, err := lnd.OpenDB(c.ChannelDB, false)
 	if err != nil {
 		return fmt.Errorf("error opening rescue DB: %w", err)
 	}
@@ -77,13 +78,14 @@ func (c *dropGraphZombiesCommand) Execute(_ *cobra.Command, _ []string) error {
 
 	edges := rwTx.ReadWriteBucket(edgeBucket)
 	if edges == nil {
-		return channeldb.ErrGraphNoEdgesFound
+		return graphdb.ErrGraphNoEdgesFound
 	}
 
 	if err := edges.DeleteNestedBucket(zombieBucket); err != nil {
 		return err
 	}
 
 	success = true
+
 	return rwTx.Commit()
 }

cmd/chantools/dumpbackup.go

@@ -50,7 +50,7 @@ func (c *dumpBackupCommand) Execute(_ *cobra.Command, _ []string) error {
 	if c.MultiFile == "" {
 		return errors.New("backup file is required")
 	}
-	multiFile := chanbackup.NewMultiFile(c.MultiFile)
+	multiFile := chanbackup.NewMultiFile(c.MultiFile, noBackupArchive)
 	keyRing := &lnd.HDKeyRing{
 		ExtendedKey: extendedKey,
 		ChainParams: chainParams,

cmd/chantools/dumpchannels.go

@@ -57,7 +57,7 @@ func (c *dumpChannelsCommand) Execute(_ *cobra.Command, _ []string) error {
 	if c.ChannelDB == "" {
 		return errors.New("channel DB is required")
 	}
-	db, err := lnd.OpenDB(c.ChannelDB, true)
+	db, _, err := lnd.OpenDB(c.ChannelDB, true)
 	if err != nil {
 		return fmt.Errorf("error opening rescue DB: %w", err)
 	}

cmd/chantools/fakechanbackup.go

@@ -126,7 +126,7 @@ func (c *fakeChanBackupCommand) Execute(_ *cobra.Command, _ []string) error {
 		return fmt.Errorf("error reading root key: %w", err)
 	}
 
-	multiFile := chanbackup.NewMultiFile(c.MultiFile)
+	multiFile := chanbackup.NewMultiFile(c.MultiFile, noBackupArchive)
 	keyRing := &lnd.HDKeyRing{
 		ExtendedKey: extendedKey,
 		ChainParams: chainParams,