Skip to content

Commit 6e4a076

Browse files
committed
derivekey: don't require --neuter for xpub input
Previously, if xpub was passed, the tool crashed without --neuter option. Now it is optional if the input is an xpub.
1 parent d3e14a4 commit 6e4a076

File tree

2 files changed

+21
-1
lines changed

2 files changed

+21
-1
lines changed

cmd/chantools/derivekey.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,7 @@ func deriveKey(extendedKey *hdkeychain.ExtendedKey, path string,
107107
}
108108

109109
privKey, xPriv := na, na
110-
if !neuter {
110+
if !neuter && wif != nil {
111111
privKey, xPriv = wif.String(), child.String()
112112
}
113113

cmd/chantools/derivekey_test.go

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -123,3 +123,23 @@ func TestDeriveKeyXpub(t *testing.T) {
123123
h.assertLogContains("03dc8655d58bd4fd4326863fe34bd5cdddbefaa3b042571" +
124124
"05eb1ab99aa05e01c2a")
125125
}
126+
127+
func TestDeriveKeyXpubNoNeuter(t *testing.T) {
128+
h := newHarness(t)
129+
130+
// Derive a specific key from xpub.
131+
derive := &deriveKeyCommand{
132+
Path: "m/5/6",
133+
rootKey: &rootKey{
134+
RootKey: "xpub661MyMwAqRbcFtXgS5sYJABqqG9YLmC4Q1Rdap" +
135+
"9gSE8NqtwybGhePY2gZ29ESFjqJoCu1Rupje8YtGqse" +
136+
"fD265TMg7usUDFdp6W1EGMcet8",
137+
},
138+
}
139+
140+
err := derive.Execute(nil, nil)
141+
require.NoError(t, err)
142+
143+
h.assertLogContains("03dc8655d58bd4fd4326863fe34bd5cdddbefaa3b042571" +
144+
"05eb1ab99aa05e01c2a")
145+
}

0 commit comments

Comments
 (0)