Skip to content

Commit 269b002

Browse files
Merge pull request #838 from lightninglabs/docs-lnd
Update lnd documentation
2 parents 98af7e6 + 0ea4c11 commit 269b002

File tree

2 files changed

+45
-0
lines changed

2 files changed

+45
-0
lines changed

docs/lnd/development_guidelines.md

Lines changed: 42 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -230,6 +230,48 @@ value, err := bar(
230230
)
231231
```
232232
233+
As long as the visual symmetry of the opening and closing parentheses is
234+
preserved, arguments that would otherwise introduce a new level of indentation
235+
are allowed to be written in a more compact form.
236+
237+
Example with inline struct creation:
238+
239+
**ACCEPTABLE**
240+
```go
241+
response, err := node.AddInvoice(
242+
ctx, &lnrpc.Invoice{
243+
Memo: "invoice",
244+
ValueMsat: int64(oneUnitMilliSat - 1),
245+
},
246+
)
247+
```
248+
249+
**PREFERRED**
250+
```go
251+
response, err := node.AddInvoice(ctx, &lnrpc.Invoice{
252+
Memo: "invoice",
253+
ValueMsat: int64(oneUnitMilliSat - 1),
254+
})
255+
```
256+
257+
Example with nested function call:
258+
259+
**ACCEPTABLE**:
260+
```go
261+
payInvoiceWithSatoshi(
262+
t.t, dave, invoiceResp2, withFailure(
263+
lnrpc.Payment_FAILED, failureNoRoute,
264+
),
265+
)
266+
```
267+
268+
**PREFERRED**:
269+
```go
270+
payInvoiceWithSatoshi(t.t, dave, invoiceResp2, withFailure(
271+
lnrpc.Payment_FAILED, failureNoRoute,
272+
))
273+
```
274+
233275
#### Exception for log and error message formatting
234276
235277
**Note that the above guidelines don't apply to log or error messages.** For

docs/lnd/release-notes/release-notes-0.19.0.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,9 @@ when running LND with an aux component injected (custom channels).
128128
such that the probability is evaluated quicker and to be more accurate in
129129
outdated scenarios.
130130

131+
* [Fix a bug](https://github.com/lightningnetwork/lnd/pull/9798) that could
132+
result in a new topology client missing a channel-close notifications.
133+
131134
# New Features
132135

133136
* Add support for [archiving channel backup](https://github.com/lightningnetwork/lnd/pull/9232)

0 commit comments

Comments
 (0)