-
Notifications
You must be signed in to change notification settings - Fork 21
multi: Bump go to 1.22.6 & litd to v0.14.0-alpha
#109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
6a581df
.github: bump upload-artifact action to v4
ViktorT-11 87a2c89
mod: bump lightning-terminal to `v0.14.0-alpha`
ViktorT-11 595d5db
lightning-node-connect: bump go to `1.22.6`
ViktorT-11 8560754
lightning-node-connect: run go mod tidy
ViktorT-11 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can squash this commit into previous one which does the go.mod update :) but non-blocking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason i separated these into different commits is that the changes between those 2 commits are actually unrelated from each other, as project hadn't run
go mod tidyfor the previously merged PR. So even though they're both changing thego.modfile, neither of the commits are actually related :).I should have clarified this, and In hindsight maybe it'd make sense to include the
go mod tidycommit as the first commit in the PR for clarification. But choosing to merge this as is to avoid another CI run.