Skip to content

Commit 08d0392

Browse files
committed
Revert "make: update VERSION_TAG to a globally-consistent build-input identifier"
This reverts commit 66d2bd1. Unfortunately, this commit leads to a "-dirty" suffix being added to built releases, on multiple environments. The reason for that is that as the "make release" build process rebuilds the app build folder, which temporarily removes the .gitkeep file in that folder. As the VERSION_TAG then gets based on a build that lacks the .gitkeep file, the build process adds the "-dirty" suffix to the version.
1 parent d66fd09 commit 08d0392

File tree

1 file changed

+1
-2
lines changed

1 file changed

+1
-2
lines changed

make/release_flags.mk

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
1-
# Create a globally-consistent, build-input identifier.
2-
VERSION_TAG = $(shell git describe --abbrev=40 --broken --tags --always)
1+
VERSION_TAG = $(shell git describe --tags)
32
VERSION_CHECK = @$(call print, "Building master with date version tag")
43

54
BUILD_SYSTEM = darwin-amd64 \

0 commit comments

Comments
 (0)