itest: increase timelock delta to reach minimum requirement

LND 0.21.0 introduces a new limit on the timelock delta of 24.
Previous limit was 18 so a change is required to bump this limit in
all tests to avoid errors.

Author: darioAnongba

itest/litd_custom_channels_test.go

@@ -3266,7 +3266,7 @@ func testCustomChannelsLiquidityEdgeCasesCore(ctx context.Context,
 		},
 		BaseFeeMsat:   31337,
 		FeeRatePpm:    443322,
-		TimeLockDelta: 19,
+		TimeLockDelta: 25,
 	})
 	require.NoError(t.t, err)
 	require.Empty(t.t, resp.FailedUpdates)
@@ -3277,7 +3277,7 @@ func testCustomChannelsLiquidityEdgeCasesCore(ctx context.Context,
 		},
 		BaseFeeMsat:   42069,
 		FeeRatePpm:    223344,
-		TimeLockDelta: 18,
+		TimeLockDelta: 24,
 	})
 	require.NoError(t.t, err)
 	require.Empty(t.t, resp.FailedUpdates)
@@ -3296,7 +3296,7 @@ func testCustomChannelsLiquidityEdgeCasesCore(ctx context.Context,
 	require.Equal(t.t, erin.PubKeyStr, invoiceHint.NodeId)
 	require.EqualValues(t.t, 31337, invoiceHint.FeeBaseMsat)
 	require.EqualValues(t.t, 443322, invoiceHint.FeeProportionalMillionths)
-	require.EqualValues(t.t, 19, invoiceHint.CltvExpiryDelta)
+	require.EqualValues(t.t, 25, invoiceHint.CltvExpiryDelta)
 
 	// Now we pay the invoice and expect the same policy with very expensive
 	// fees to be used.

itest/litd_firewall_test.go

@@ -847,7 +847,7 @@ func testSessionLinking(net *NetworkHarness, t *harnessTest) {
 			Scope: &lnrpc.PolicyUpdateRequest_ChanPoint{
 				ChanPoint: chanPoint,
 			},
-			TimeLockDelta: 20,
+			TimeLockDelta: 24,
 			MaxHtlcMsat:   100000,
 		}, caveatCreds1,
 	)
@@ -939,7 +939,7 @@ func testSessionLinking(net *NetworkHarness, t *harnessTest) {
 			Scope: &lnrpc.PolicyUpdateRequest_ChanPoint{
 				ChanPoint: chanPoint,
 			},
-			TimeLockDelta: 20,
+			TimeLockDelta: 24,
 			MaxHtlcMsat:   100000,
 		}, caveatCreds1,
 	)
@@ -1591,7 +1591,7 @@ func testRateLimitAndPrivacyMapper(net *NetworkHarness, t *harnessTest) {
 			Scope: &lnrpc.PolicyUpdateRequest_ChanPoint{
 				ChanPoint: chanPoint,
 			},
-			TimeLockDelta: 20,
+			TimeLockDelta: 24,
 			MaxHtlcMsat:   100000,
 		}, caveatCreds,
 	)
@@ -1633,7 +1633,7 @@ func testRateLimitAndPrivacyMapper(net *NetworkHarness, t *harnessTest) {
 			Scope: &lnrpc.PolicyUpdateRequest_ChanPoint{
 				ChanPoint: chanPoint,
 			},
-			TimeLockDelta: 20,
+			TimeLockDelta: 24,
 			MaxHtlcMsat:   100000,
 		}, caveatCreds,
 	)
@@ -1931,7 +1931,7 @@ func testChanPolicyBoundsRule(net *NetworkHarness, t *harnessTest) {
 			Scope: &lnrpc.PolicyUpdateRequest_ChanPoint{
 				ChanPoint: chanPoint,
 			},
-			TimeLockDelta: 20,
+			TimeLockDelta: 24,
 			MaxHtlcMsat:   100000,
 		}, caveatCreds,
 	)
@@ -1946,7 +1946,7 @@ func testChanPolicyBoundsRule(net *NetworkHarness, t *harnessTest) {
 			Scope: &lnrpc.PolicyUpdateRequest_ChanPoint{
 				ChanPoint: chanPoint,
 			},
-			TimeLockDelta: 20,
+			TimeLockDelta: 24,
 			MaxHtlcMsat:   100000,
 		}, caveatCreds,
 	)
@@ -1961,7 +1961,7 @@ func testChanPolicyBoundsRule(net *NetworkHarness, t *harnessTest) {
 			Scope: &lnrpc.PolicyUpdateRequest_ChanPoint{
 				ChanPoint: chanPoint,
 			},
-			TimeLockDelta: 10,
+			TimeLockDelta: 24,
 			MaxHtlcMsat:   100000,
 		}, caveatCreds,
 	)
@@ -1976,7 +1976,7 @@ func testChanPolicyBoundsRule(net *NetworkHarness, t *harnessTest) {
 			Scope: &lnrpc.PolicyUpdateRequest_ChanPoint{
 				ChanPoint: chanPoint,
 			},
-			TimeLockDelta: 20,
+			TimeLockDelta: 24,
 			MaxHtlcMsat:   100000,
 		}, caveatCreds,
 	)
@@ -1991,7 +1991,7 @@ func testChanPolicyBoundsRule(net *NetworkHarness, t *harnessTest) {
 			Scope: &lnrpc.PolicyUpdateRequest_ChanPoint{
 				ChanPoint: chanPoint,
 			},
-			TimeLockDelta: 20,
+			TimeLockDelta: 24,
 			MaxHtlcMsat:   100000,
 		}, caveatCreds,
 	)
@@ -2212,7 +2212,7 @@ func testPeerAndChannelRestrictRules(net *NetworkHarness, t *harnessTest) {
 			Scope: &lnrpc.PolicyUpdateRequest_ChanPoint{
 				ChanPoint: chanPoint,
 			},
-			TimeLockDelta: 20,
+			TimeLockDelta: 24,
 			MaxHtlcMsat:   100000,
 		}, caveatCreds,
 	)
@@ -2252,7 +2252,7 @@ func testPeerAndChannelRestrictRules(net *NetworkHarness, t *harnessTest) {
 			Scope: &lnrpc.PolicyUpdateRequest_ChanPoint{
 				ChanPoint: chanPoint,
 			},
-			TimeLockDelta: 20,
+			TimeLockDelta: 24,
 			MaxHtlcMsat:   100000,
 		}, caveatCreds,
 	)
@@ -2292,7 +2292,7 @@ func testPeerAndChannelRestrictRules(net *NetworkHarness, t *harnessTest) {
 			Scope: &lnrpc.PolicyUpdateRequest_ChanPoint{
 				ChanPoint: chanPoint,
 			},
-			TimeLockDelta: 20,
+			TimeLockDelta: 24,
 			MaxHtlcMsat:   100000,
 		}, caveatCreds,
 	)
@@ -2329,7 +2329,7 @@ func testPeerAndChannelRestrictRules(net *NetworkHarness, t *harnessTest) {
 			Scope: &lnrpc.PolicyUpdateRequest_ChanPoint{
 				ChanPoint: chanPoint,
 			},
-			TimeLockDelta: 20,
+			TimeLockDelta: 24,
 			MaxHtlcMsat:   100000,
 		}, caveatCreds,
 	)