itest: add test case for RFQ quote compat fix

Adds a test case to validate the fix in
lightninglabs/taproot-assets#1583, by adding a test that:
 - Creates two asset channels between Alice and Bob
 - Creates a BTC channel between Bob and Charlie
 - The two asset channels each have a different asset in them
 - The balance of the pences channel is decreased (lower bandwidth)
 - An RFQ payment is attempted, with pences as the payment asset

Author: guggero

itest/litd_custom_channels_test.go

@@ -4770,3 +4770,146 @@ func testCustomChannelsSelfPayment(ctx context.Context, net *NetworkHarness,
 		)
 	}
 }
+
+// testCustomChannelsMultiChannelPathfinding tests that multiple channels with
+// different assets are properly considered when pathfinding for payments.
+func testCustomChannelsMultiChannelPathfinding(ctx context.Context,
+	net *NetworkHarness, t *harnessTest) {
+
+	lndArgs := slices.Clone(lndArgsTemplate)
+	litdArgs := slices.Clone(litdArgsTemplate)
+
+	// We use Alice as the proof courier. But in order for Alice to also
+	// use itself, we need to define its port upfront.
+	alicePort := port.NextAvailablePort()
+	litdArgs = append(litdArgs, fmt.Sprintf(
+		"--taproot-assets.proofcourieraddr=%s://%s",
+		proof.UniverseRpcCourierType,
+		fmt.Sprintf(node.ListenerFormat, alicePort),
+	))
+
+	// Next, we'll make Alice and Bob, who will be the main nodes under
+	// test.
+	alice, err := net.NewNodeWithPort(
+		t.t, "Alice", lndArgs, false, true, alicePort, litdArgs...,
+	)
+	require.NoError(t.t, err)
+	bob, err := net.NewNode(
+		t.t, "Bob", lndArgs, false, true, litdArgs...,
+	)
+	require.NoError(t.t, err)
+
+	charlie, err := net.NewNode(
+		t.t, "Charlie", lndArgs, false, true, litdArgs...,
+	)
+	require.NoError(t.t, err)
+
+	// Now we'll connect all nodes, and also fund them with some coins.
+	nodes := []*HarnessNode{alice, bob, charlie}
+	connectAllNodes(t.t, net, nodes)
+	fundAllNodes(t.t, net, nodes)
+
+	aliceTap := newTapClient(t.t, alice)
+
+	// Next, we'll mint an asset for Alice, who will be the node that opens
+	// the channel outbound.
+	mintedAssets1 := itest.MintAssetsConfirmBatch(
+		t.t, t.lndHarness.Miner.Client, aliceTap,
+		[]*mintrpc.MintAssetRequest{
+			{
+				Asset: itestAsset,
+			},
+		},
+	)
+	cents := mintedAssets1[0]
+	assetIDCents := cents.AssetGenesis.AssetId
+
+	// We'll mint a second asset, representing british pences.
+	mintedAssets2 := itest.MintAssetsConfirmBatch(
+		t.t, t.lndHarness.Miner.Client, aliceTap,
+		[]*mintrpc.MintAssetRequest{
+			{
+				Asset: &mintrpc.MintAsset{
+					AssetType: taprpc.AssetType_NORMAL,
+					Name:      "itest-asset-pences",
+					AssetMeta: dummyMetaData,
+					Amount:    1_000_000,
+				},
+			},
+		},
+	)
+	pences := mintedAssets2[0]
+	assetIDPences := pences.AssetGenesis.AssetId
+
+	t.Logf("Minted %d lightning cents and %d lightning pences, syncing "+
+		"universes...", cents.Amount, pences.Amount)
+	syncUniverses(t.t, aliceTap, bob)
+	t.Logf("Universes synced between all nodes, distributing assets...")
+
+	// With the assets created, and synced -- we'll now open the channel
+	// between Alice and Bob.
+	t.Logf("Opening asset channel with cents...")
+	assetFundResp1, err := aliceTap.FundChannel(
+		ctx, &tchrpc.FundChannelRequest{
+			AssetAmount:        fundingAmount,
+			AssetId:            assetIDCents,
+			PeerPubkey:         bob.PubKey[:],
+			FeeRateSatPerVbyte: 5,
+		},
+	)
+	require.NoError(t.t, err)
+	t.Logf("Funded cents channel between Alice and Bob: %v", assetFundResp1)
+
+	// With the channel open, mine a block to confirm it.
+	mineBlocks(t, net, 6, 1)
+
+	t.Logf("Opening asset channel with pences...")
+	assetFundResp2, err := aliceTap.FundChannel(
+		ctx, &tchrpc.FundChannelRequest{
+			AssetAmount:        fundingAmount,
+			AssetId:            assetIDPences,
+			PeerPubkey:         bob.PubKey[:],
+			FeeRateSatPerVbyte: 5,
+		},
+	)
+	require.NoError(t.t, err)
+	t.Logf("Funded pences channel between Alice and Bob: %v",
+		assetFundResp2)
+
+	// With the channel open, mine a block to confirm it.
+	mineBlocks(t, net, 6, 1)
+
+	t.Logf("Opening normal channel between Bob and Charlie...")
+	satChanPoint := openChannelAndAssert(
+		t, net, bob, charlie, lntest.OpenChannelParams{
+			Amt:         10_000_000,
+			SatPerVByte: 5,
+		},
+	)
+	defer closeChannelAndAssert(t, net, charlie, satChanPoint, false)
+
+	// Before we start sending out payments, let's make sure each node can
+	// see the other one in the graph and has all required features.
+	require.NoError(t.t, t.lndHarness.AssertNodeKnown(alice, bob))
+	require.NoError(t.t, t.lndHarness.AssertNodeKnown(bob, alice))
+	require.NoError(t.t, t.lndHarness.AssertNodeKnown(alice, charlie))
+
+	// We now make sure that the balance of the cents channel is higher on
+	// Alice, by sending some of the pences to Bob in a keysend payment.
+	const pencesKeySendAmount = 5_000
+	sendAssetKeySendPayment(
+		t.t, alice, bob, pencesKeySendAmount, assetIDPences,
+		fn.None[int64](),
+	)
+
+	logBalance(t.t, nodes, assetIDCents, "cents, after keysend pences")
+	logBalance(t.t, nodes, assetIDPences, "pences, after keysend pences")
+
+	// We now create a normal invoice on Charlie for some amount, then try
+	// to pay it with pences.
+	const btcInvoiceAmount = 500_00
+	invoiceResp := createNormalInvoice(t.t, charlie, btcInvoiceAmount)
+	payInvoiceWithAssets(
+		t.t, alice, bob, invoiceResp.PaymentRequest, assetIDPences,
+	)
+}

itest/litd_test_list_on_test.go

@@ -133,4 +133,9 @@ var allTestCases = []*testCase{
 		test:       testCustomChannelsMultiRFQReceive,
 		noAliceBob: true,
 	},
+	{
+		name:       "custom channels multi channel pathfinding",
+		test:       testCustomChannelsMultiChannelPathfinding,
+		noAliceBob: true,
+	},
 }