itest: assert failure reason for normal invoice payments

Author: guggero

itest/assets_test.go

@@ -813,7 +813,8 @@ func createAndPayNormalInvoice(t *testing.T, src, rfqPeer, dst *HarnessNode,
 
 func payInvoiceWithSatoshi(t *testing.T, payer *HarnessNode,
 	invoice *lnrpc.AddInvoiceResponse,
-	expectedStatus lnrpc.Payment_PaymentStatus, expectTimeout bool) {
+	expectedStatus lnrpc.Payment_PaymentStatus,
+	failReason fn.Option[lnrpc.PaymentFailureReason], expectTimeout bool) {
 
 	ctxb := context.Background()
 	ctxt, cancel := context.WithTimeout(ctxb, defaultTimeout)
@@ -834,6 +835,11 @@ func payInvoiceWithSatoshi(t *testing.T, payer *HarnessNode,
 	} else {
 		require.NoError(t, err)
 		require.Equal(t, expectedStatus, result.Status)
+
+		expectedReason := failReason.UnwrapOr(
+			lnrpc.PaymentFailureReason_FAILURE_REASON_NONE,
+		)
+		require.Equal(t, expectedReason, result.FailureReason)
 	}
 }
 

itest/litd_custom_channels_test.go

@@ -49,8 +49,6 @@ var (
 	}
 
 	shortTimeout = time.Second * 5
-
-	defaultPaymentStatusOpt = fn.None[lnrpc.Payment_PaymentStatus]()
 )
 
 var (
@@ -527,7 +525,8 @@ func testCustomChannels(_ context.Context, net *NetworkHarness,
 		t.t, charlie, dave, daveInvoiceAssetAmount, assetID,
 	)
 	payInvoiceWithSatoshi(
-		t.t, charlie, invoiceResp, lnrpc.Payment_FAILED, false,
+		t.t, charlie, invoiceResp, lnrpc.Payment_FAILED,
+		fn.Some(failureIncorrectDetails), false,
 	)
 	logBalance(t.t, nodes, assetID, "after asset invoice paid with sats")
 
@@ -575,7 +574,8 @@ func testCustomChannels(_ context.Context, net *NetworkHarness,
 		t.t, erin, fabia, fabiaInvoiceAssetAmount2, assetID,
 	)
 	payInvoiceWithSatoshi(
-		t.t, dave, invoiceResp, lnrpc.Payment_SUCCEEDED, false,
+		t.t, dave, invoiceResp, lnrpc.Payment_SUCCEEDED,
+		fn.None[lnrpc.PaymentFailureReason](), false,
 	)
 	logBalance(t.t, nodes, assetID, "after invoice")
 
@@ -1009,7 +1009,8 @@ func testCustomChannelsGroupedAsset(_ context.Context, net *NetworkHarness,
 		t.t, erin, fabia, fabiaInvoiceAssetAmount2, assetID,
 	)
 	payInvoiceWithSatoshi(
-		t.t, dave, invoiceResp, lnrpc.Payment_SUCCEEDED, false,
+		t.t, dave, invoiceResp, lnrpc.Payment_SUCCEEDED,
+		fn.None[lnrpc.PaymentFailureReason](), false,
 	)
 	logBalance(t.t, nodes, assetID, "after invoice")
 
@@ -2019,7 +2020,8 @@ func testCustomChannelsLiquidityEdgeCases(_ context.Context,
 	// amount of 354 sats.
 	invoiceResp = createAssetInvoice(t.t, dave, charlie, 1, assetID)
 	payInvoiceWithSatoshi(
-		t.t, yara, invoiceResp, lnrpc.Payment_FAILED, false,
+		t.t, yara, invoiceResp, lnrpc.Payment_FAILED,
+		fn.Some(failureNoRoute), false,
 	)
 
 	logBalance(t.t, nodes, assetID, "after small payment (asset "+