swaps: remove api polling for pending swaps

Author: jamaljsr

app/src/__stories__/HistoryPage.stories.tsx

@@ -23,15 +23,13 @@ const updateSwapsStatus = (swaps: Swap[]) => {
 
 export const Default = () => {
   const store = useStore();
-  store.swapStore.stopAutoPolling();
   updateSwapsStatus(store.swapStore.sortedSwaps);
   return <HistoryPage />;
 };
 
 export const InsideLayout = () => {
   const store = useStore();
   store.uiStore.page = 'history';
-  store.swapStore.stopAutoPolling();
   updateSwapsStatus(store.swapStore.sortedSwaps);
   return (
     <Layout>

app/src/__stories__/ProcessingSwaps.stories.tsx

@@ -66,14 +66,12 @@ const delay = (timeout: number) =>
 
 export const AllSwapStates = () => {
   const store = useStore();
-  store.swapStore.stopAutoPolling();
   store.swapStore.swaps = createSwaps();
   return <ProcessingSwaps />;
 };
 
 export const LoopInProgress = () => {
   const store = useStore();
-  store.swapStore.stopAutoPolling();
   const swap = mockSwap(LOOP_IN, INITIATED);
   store.swapStore.swaps = observable.map({ [swap.id]: swap });
 
@@ -98,7 +96,6 @@ export const LoopInProgress = () => {
 
 export const LoopOutProgress = () => {
   const store = useStore();
-  store.swapStore.stopAutoPolling();
   const swap = mockSwap(LOOP_OUT, INITIATED);
   store.swapStore.swaps = observable.map({ [swap.id]: swap });
 

app/src/__tests__/store/swapStore.spec.ts

@@ -75,58 +75,4 @@ describe('SwapStore', () => {
     swap.type = type;
     expect(swap.typeName).toEqual(label);
   });
-
-  it('should poll for swap updates', async () => {
-    await store.fetchSwaps();
-    const swap = store.sortedSwaps[0];
-    // create a pending swap to trigger auto-polling
-    swap.state = LOOP.SwapState.INITIATED;
-    expect(store.pendingSwaps).toHaveLength(1);
-    // wait for polling to start
-    await waitFor(() => {
-      expect(store.pollingInterval).toBeDefined();
-    });
-    // change the swap to complete
-    swap.state = LOOP.SwapState.SUCCESS;
-    expect(store.pendingSwaps).toHaveLength(0);
-    // confirm polling has stopped
-    await waitFor(() => {
-      expect(store.pollingInterval).toBeUndefined();
-    });
-  });
-
-  it('should handle startPolling when polling is already running', () => {
-    expect(store.pollingInterval).toBeUndefined();
-    store.startPolling();
-    expect(store.pollingInterval).toBeDefined();
-    store.startPolling();
-    expect(store.pollingInterval).toBeDefined();
-  });
-
-  it('should handle stopPolling when polling is already stopped', () => {
-    expect(store.pollingInterval).toBeUndefined();
-    store.stopPolling();
-    expect(store.pollingInterval).toBeUndefined();
-  });
-
-  it('should stop polling if there is an error fetching swaps', async () => {
-    await store.fetchSwaps();
-    const swap = store.sortedSwaps[0];
-    // create a pending swap to trigger auto-polling
-    swap.state = LOOP.SwapState.INITIATED;
-    expect(store.pendingSwaps).toHaveLength(1);
-    // wait for polling to start
-    await waitFor(() => {
-      expect(store.pollingInterval).toBeDefined();
-    });
-    // induce a failure when fetching swaps
-    grpcMock.unary.mockImplementationOnce(desc => {
-      if (desc.methodName === 'ListSwaps') throw new Error('test-err');
-      return undefined as any;
-    });
-    // confirm polling has stopped
-    await waitFor(() => {
-      expect(store.pollingInterval).toBeUndefined();
-    });
-  });
 });

app/src/store/stores/swapStore.ts

@@ -1,26 +1,18 @@
 import {
   action,
   computed,
-  IReactionDisposer,
   observable,
   ObservableMap,
-  reaction,
   runInAction,
   toJS,
   values,
 } from 'mobx';
 import { SwapStatus } from 'types/generated/loop_pb';
-import { IS_PROD, IS_TEST } from 'config';
 import { Store } from 'store';
 import { Swap } from '../models';
 
 export default class SwapStore {
   private _store: Store;
-  /** a reference to the polling timer, needed to stop polling */
-  pollingInterval?: NodeJS.Timeout;
-  /** the mobx disposer func to cancel automatic polling */
-  stopAutoPolling: IReactionDisposer;
-
   /** the collection of swaps */
   @observable swaps: ObservableMap<string, Swap> = observable.map();
 
@@ -29,21 +21,6 @@ export default class SwapStore {
 
   constructor(store: Store) {
     this._store = store;
-
-    // automatically start & stop polling for swaps if there are any pending
-    this.stopAutoPolling = reaction(
-      () => this.pendingSwaps.length,
-      (length: number) => {
-        if (length > 0) {
-          this.startPolling();
-        } else {
-          this.stopPolling();
-          // also update our channels and balances when the loop is complete
-          this._store.channelStore.fetchChannels();
-          this._store.nodeStore.fetchBalances();
-        }
-      },
-    );
   }
 
   /** swaps sorted by created date descending */
@@ -103,7 +80,6 @@ export default class SwapStore {
       });
     } catch (error) {
       this._store.uiStore.handleError(error, 'Unable to fetch Swaps');
-      if (this.pollingInterval) this.stopPolling();
     }
   }
 
@@ -127,26 +103,6 @@ export default class SwapStore {
     this._store.channelStore.fetchChannels();
   }
 
-  @action.bound
-  startPolling() {
-    if (this.pollingInterval) this.stopPolling();
-    this._store.log.info('start polling for swap updates');
-    const ms = IS_PROD ? 60 * 1000 : IS_TEST ? 100 : 1000;
-    this.pollingInterval = setInterval(this.fetchSwaps, ms);
-  }
-
-  @action.bound
-  stopPolling() {
-    this._store.log.info('stop polling for swap updates');
-    if (this.pollingInterval) {
-      clearInterval(this.pollingInterval);
-      this.pollingInterval = undefined;
-      this._store.log.info('polling stopped');
-    } else {
-      this._store.log.info('polling was already stopped');
-    }
-  }
-
   /** exports the sorted list of swaps to CSV file */
   @action.bound
   exportSwaps() {