itest: add custom channels multi rfq receive itest

Author: GeorgeTsagk

itest/litd_custom_channels_test.go

@@ -48,7 +48,7 @@ var (
 		AssetType: taprpc.AssetType_NORMAL,
 		Name:      "itest-asset-cents",
 		AssetMeta: dummyMetaData,
-		Amount:    1_000_000,
+		Amount:    10_000_000,
 	}
 
 	shortTimeout = time.Second * 5
@@ -2720,14 +2720,15 @@ func testCustomChannelsLiquidtyEdgeCasesCore(ctx context.Context,
 	t.Logf("Universes synced between all nodes, distributing assets...")
 
 	const (
-		daveFundingAmount = uint64(400_000)
-		erinFundingAmount = uint64(200_000)
+		daveFundingAmount    = uint64(400_000)
+		erinFundingAmount    = uint64(200_000)
+		charlieFundingAmount = uint64(400_000)
 	)
-	charlieFundingAmount := cents.Amount - uint64(2*400_000)
+	// charlieFundingAmount := cents.Amount - uint64(2*400_000)
 
 	_, _, _ = createTestAssetNetwork(
 		t, net, charlieTap, daveTap, erinTap, fabiaTap, yaraTap,
-		universeTap, cents, 400_000, charlieFundingAmount,
+		universeTap, cents, 500_000, charlieFundingAmount,
 		daveFundingAmount, erinFundingAmount, 0,
 	)
 
@@ -3126,6 +3127,160 @@ func testCustomChannelsLiquidityEdgeCasesGroup(ctx context.Context,
 	testCustomChannelsLiquidtyEdgeCasesCore(ctx, net, t, true)
 }
 
+// testCustomChannelsMultiRFQReceive tests that a node creating an invoice with
+// multiple RFQ quotes can actually guide the payer into using multiple private
+// taproot asset channels to pay the invoice.
+func testCustomChannelsMultiRFQReceive(ctx context.Context, net *NetworkHarness,
+	t *harnessTest) {
+
+	lndArgs := slices.Clone(lndArgsTemplate)
+	litdArgs := slices.Clone(litdArgsTemplate)
+
+	// Explicitly set the proof courier as Zane (now has no other role
+	// other than proof shuffling), otherwise a hashmail courier will be
+	// used. For the funding transaction, we're just posting it and don't
+	// expect a true receiver.
+	zane, err := net.NewNode(
+		t.t, "Zane", lndArgs, false, true, litdArgs...,
+	)
+	require.NoError(t.t, err)
+
+	litdArgs = append(litdArgs, fmt.Sprintf(
+		"--taproot-assets.proofcourieraddr=%s://%s",
+		proof.UniverseRpcCourierType, zane.Cfg.LitAddr(),
+	))
+
+	charlie, err := net.NewNode(
+		t.t, "Charlie", lndArgs, false, true, litdArgs...,
+	)
+	require.NoError(t.t, err)
+
+	dave, err := net.NewNode(t.t, "Dave", lndArgs, false, true, litdArgs...)
+	require.NoError(t.t, err)
+	erin, err := net.NewNode(t.t, "Erin", lndArgs, false, true, litdArgs...)
+	require.NoError(t.t, err)
+	fabia, err := net.NewNode(
+		t.t, "Fabia", lndArgs, false, true, litdArgs...,
+	)
+	require.NoError(t.t, err)
+	yara, err := net.NewNode(
+		t.t, "Yara", lndArgs, false, true, litdArgs...,
+	)
+	require.NoError(t.t, err)
+
+	nodes := []*HarnessNode{charlie, dave, erin, fabia, yara}
+	connectAllNodes(t.t, net, nodes)
+	fundAllNodes(t.t, net, nodes)
+
+	// The topology we are going for looks like the following:
+	//
+	//            /---[sats]--> Erin --[assets]--\
+	//           /                                \
+	//          /                                  \
+	// Charlie  -----[sats]-->  Dave  --[assets]---->Fabia
+	//          \                                  /
+	//           \                                /
+	//            \---[sats]--> Yara --[assets]--/
+	//
+
+	// Let's open the normal sats channels between Charlie and the routing
+	// peers.
+	_ = openChannelAndAssert(
+		t, net, charlie, erin, lntest.OpenChannelParams{
+			Amt:         10_000_000,
+			SatPerVByte: 5,
+		},
+	)
+
+	_ = openChannelAndAssert(
+		t, net, charlie, dave, lntest.OpenChannelParams{
+			Amt:         10_000_000,
+			SatPerVByte: 5,
+		},
+	)
+
+	_ = openChannelAndAssert(
+		t, net, charlie, yara, lntest.OpenChannelParams{
+			Amt:         10_000_000,
+			SatPerVByte: 5,
+		},
+	)
+
+	// Let's create the tap clients.
+	universeTap := newTapClient(t.t, zane)
+	charlieTap := newTapClient(t.t, charlie)
+	daveTap := newTapClient(t.t, dave)
+	erinTap := newTapClient(t.t, erin)
+	fabiaTap := newTapClient(t.t, fabia)
+	yaraTap := newTapClient(t.t, yara)
+
+	assetReq := itest.CopyRequest(&mintrpc.MintAssetRequest{
+		Asset: itestAsset,
+	})
+
+	assetReq.Asset.NewGroupedAsset = true
+
+	// Mint an asset on Charlie and sync all nodes to Charlie as the
+	// universe.
+	mintedAssets := itest.MintAssetsConfirmBatch(
+		t.t, t.lndHarness.Miner.Client, charlieTap,
+		[]*mintrpc.MintAssetRequest{assetReq},
+	)
+	cents := mintedAssets[0]
+	assetID := cents.AssetGenesis.AssetId
+	groupID := cents.GetAssetGroup().GetTweakedGroupKey()
+
+	syncUniverses(t.t, charlieTap, dave, erin, fabia, yara)
+
+	createTestMultiRFQAssetNetwork(
+		t, net, charlieTap, daveTap, erinTap, fabiaTap, yaraTap,
+		universeTap, cents, 10_000, 10_000, 10_000,
+	)
+
+	logBalance(t.t, nodes, assetID, "before multi-rfq receive")
+
+	hodlInv := createAssetHodlInvoice(t.t, nil, fabia, 20_000, assetID)
+
+	payInvoiceWithSatoshi(
+		t.t, charlie, &lnrpc.AddInvoiceResponse{
+			PaymentRequest: hodlInv.payReq,
+		},
+		withGroupKey(groupID),
+		withFailure(lnrpc.Payment_IN_FLIGHT, failureNone),
+	)
+
+	logBalance(t.t, nodes, assetID, "after inflight multi-rfq")
+
+	// TODO: assert minNumHtlcs after rebase
+
+	// Now let's cancel the invoice and assert that all inbound channels
+	// have cleared their HTLCs.
+	payHash := hodlInv.preimage.Hash()
+	_, err = fabia.InvoicesClient.CancelInvoice(
+		ctx, &invoicesrpc.CancelInvoiceMsg{
+			PaymentHash: payHash[:],
+		},
+	)
+	require.NoError(t.t, err)
+
+	assertNumHtlcs(t.t, dave, 0)
+	assertNumHtlcs(t.t, erin, 0)
+	assertNumHtlcs(t.t, yara, 0)
+
+	logBalance(t.t, nodes, assetID, "after cancelled hodl")
+
+	// Now let's create a normal invoice that will be settled once all the
+	// HTLCs have been received. This is only possible because the payer
+	// uses multiple bolt11 hop hints to reach the destination.
+	invoiceResp := createAssetInvoice(t.t, nil, fabia, 15_000, assetID)
+
+	payInvoiceWithSatoshi(
+		t.t, charlie, invoiceResp, withGroupKey(groupID),
+	)
+
+	logBalance(t.t, nodes, assetID, "after multi-rfq receive")
+}
+
 // testCustomChannelsStrictForwarding is a test that tests the strict forwarding
 // behavior of a node when it comes to paying asset invoices with assets and
 // BTC invoices with satoshis.

itest/litd_test_list_on_test.go

@@ -114,4 +114,9 @@ var allTestCases = []*testCase{
 		test:       testCustomChannelsDecodeAssetInvoice,
 		noAliceBob: true,
 	},
+	{
+		name:       "test custom channels multi rfq",
+		test:       testCustomChannelsMultiRFQReceive,
+		noAliceBob: true,
+	},
 }